Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing docs for trim warning codes #42315

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Add missing docs for trim warning codes #42315

merged 4 commits into from
Aug 26, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 23, 2024 •
edited by github-actions bot
Loading

@sbomer sbomer requested a review from a team August 23, 2024 18:47
@sbomer sbomer requested review from adegeo and a team as code owners August 23, 2024 18:47
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Aug 23, 2024
jtschuster
jtschuster approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments

docs/core/deploying/trimming/trim-warnings/il2122.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/trim-warnings/il2071.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/trim-warnings/il2076.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/trim-warnings/il2081.md Outdated Show resolved Hide resolved
docs/core/deploying/trimming/trim-warnings/il2122.md Show resolved Hide resolved
@sbomer
PR feedback
36f2879 
- Improve example for IL2122
- 'target method or type'
@sbomer
Fix warnings
361b476
@sbomer
Fix warnings
bfc1ac0
@sbomer sbomer merged commit 8bc010a into dotnet:main Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtschuster jtschuster jtschuster approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

Assignees
No one assigned
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

Document new IL#### error codes
3 participants
@sbomer @jtschuster @dotnet-bot