Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migrate-from-newtonsoft.md #42246

Merged
merged 23 commits into from
Aug 27, 2024
Merged

Update migrate-from-newtonsoft.md #42246

merged 23 commits into from
Aug 27, 2024

Conversation

anandmeg
Copy link
Contributor

@anandmeg anandmeg commented Aug 20, 2024

Incorporate github copilot for VS use case
@anandmeg anandmeg requested review from gewarren and a team as code owners August 20, 2024 00:38
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 20, 2024
@anandmeg anandmeg marked this pull request as draft August 20, 2024 00:38
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 20, 2024
anandmeg and others added 2 commits August 20, 2024 08:59
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren
Copy link
Contributor

@anandmeg You can batch suggestions into a single commit if you accept them from the "Files changed" tab. That helps to cut down on the no. of email notifications and OPS builds.

@anandmeg
Copy link
Contributor Author

@anandmeg You can batch suggestions into a single commit if you accept them from the "Files changed" tab. That helps to cut down on the no. of email notifications and OPS builds.

Thanks for the tip, @gewarren. Pardon the multiple emails as this PR is still WIP as I continue to iterate and incorporate feedback. I'll mark it ready for review once its final.

@anandmeg anandmeg marked this pull request as ready for review August 26, 2024 03:44
@anandmeg anandmeg marked this pull request as draft August 26, 2024 04:45
@anandmeg anandmeg marked this pull request as ready for review August 26, 2024 04:45
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren enabled auto-merge (squash) August 27, 2024 23:51
@gewarren gewarren merged commit bcbb64b into dotnet:main Aug 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants