Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 40072 #42020

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Fix for 40072 #42020

merged 4 commits into from
Aug 26, 2024

Conversation

@samwherever samwherever requested review from BillWagner and a team as code owners August 2, 2024 18:57
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 2, 2024
Copy link
Contributor Author

@samwherever samwherever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inadvertently also included my code for trying to fix #38994 in this

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @samwherever

Sorry for the delay. I was out when this was opened, and it slipped through the cracks when I came back from vacation.

I'll :shipit: as soon as the build finishes.

@BillWagner BillWagner enabled auto-merge (squash) August 26, 2024 16:13
@samwherever
Copy link
Contributor Author

thanks @BillWagner and i hope the vacation was restful!

@BillWagner BillWagner merged commit f2f624a into dotnet:main Aug 26, 2024
8 checks passed
@samwherever samwherever deleted the fix-40072 branch August 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to this article from all articles in this section
3 participants