Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnsafeAccessor breaking change #41941

Merged
merged 3 commits into from
Jul 31, 2024
Merged

UnsafeAccessor breaking change #41941

merged 3 commits into from
Jul 31, 2024

Conversation

gewarren
Copy link
Contributor

Fixes #41769

@gewarren gewarren requested review from AaronRobinsonMSFT and a team July 30, 2024 01:24
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

BillWagner
BillWagner approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I had a couple nits to look at.

docs/core/compatibility/core-libraries/9.0/unsafeaccessor-generics.md Outdated Show resolved Hide resolved
docs/core/compatibility/core-libraries/9.0/unsafeaccessor-generics.md Outdated Show resolved Hide resolved
@gewarren gewarren changed the title UnsafeaAccessor breaking change UnsafeAccessor breaking change Jul 30, 2024
@gewarren gewarren closed this Jul 30, 2024
@gewarren gewarren reopened this Jul 30, 2024
@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 30, 2024
@gewarren gewarren merged commit 1a801bc into dotnet:main Jul 31, 2024
8 checks passed
@gewarren gewarren deleted the unsafeaccessor branch July 31, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.

[Breaking change]: Unintentional UnsafeAccessor support for non-open generics is altered in .NET 9.
4 participants
@gewarren @BillWagner @AaronRobinsonMSFT @dotnet-bot