Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add day of week abbreviation difference #41833

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Add day of week abbreviation difference #41833

merged 3 commits into from
Jul 19, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 18, 2024 •
edited by github-actions bot

@dotnet-bot dotnet-bot added this to the July 2024 milestone Jul 18, 2024
@gewarren gewarren requested a review from tarekgh July 18, 2024 22:47
@gewarren gewarren requested a review from a team July 18, 2024 22:51
@tarekgh
Copy link
Member

tarekgh commented Jul 19, 2024

title: "Globalization and ICU"

Could you please add section in this doc similar to the Day-of-week abbreviations section added in the icu-globlaization-api doc?

Refers to: docs/core/extensions/globalization-icu.md:3 in 7902d09. [](commit_id = 7902d09, deletion_comment = False)

tarekgh
tarekgh approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issue and fixing the misspelling and writing in other docs. I left a minor ask. LGTM!

@gewarren gewarren enabled auto-merge (squash) July 19, 2024 17:09
@gewarren gewarren merged commit 0149e1e into dotnet:main Jul 19, 2024
9 checks passed
Evangelink pushed a commit to Evangelink/docs that referenced this pull request Jul 24, 2024
@gewarren @Evangelink
Add day of week abbreviation difference (dotnet#41833)
7df4dc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gewarren @tarekgh @IEvangelist @dotnet-bot