Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated unit test doc to use MsTest instead of xUnit test #41333

Merged

Conversation

SrushtiPasari94
Copy link
Contributor

@SrushtiPasari94 SrushtiPasari94 commented Jun 7, 2024

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/architecture/maui/unit-testing.md Unit testing

@dotnet-bot dotnet-bot added this to the June 2024 milestone Jun 7, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jun 7, 2024
@IEvangelist
Copy link
Member

This is part of an eBook, and the authors source code is shared to the readers. Unless the source code changes, we shouldn't change the content. What's the thinking here, MSTest is Microsoft owned, so then that's what we should show?

I just looked; the source code was recently archived — so we can change this: https://github.com/dotnet-architecture/eshop-mobile-client/blob/main/eShopOnContainers.UnitTests/Services/BasketServiceTests.cs

/CC @jamesmontemagno

@jamesmontemagno
Copy link
Member

I just had @SrushtiPasari94 convert it over: dotnet/eShop#409 :) this is for the v2 book so should be good. I'll review today

@jamesmontemagno
Copy link
Member

#sign-off

@IEvangelist IEvangelist merged commit f5c38c8 into dotnet:main Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-architecture/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants