Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes-that-control-xml-serialization.md #40263

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

alundporchsoftware
Copy link
Contributor

@alundporchsoftware alundporchsoftware commented Mar 29, 2024

Summary

The System.Obsolete attribute has prevented serialization in the XMLSerializer since .NET 3.5. This PR adds an entry to include the Obsolete attribute.

Fixes #40232


Internal previews

📄 File 🔗 Preview link
docs/standard/serialization/attributes-that-control-xml-serialization.md Attributes That Control XML Serialization

The System.Obsolete attribute has prevented serialization in the XMLSerializer since .NET 3.5 (see https://weblogs.asp.net/psteele/xml-serialization-and-the-obsolete-attribute). It should be included in this list of attributes, so that the documentation reflects this interaction.
@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 29, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Mar 29, 2024
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alundporchsoftware. Could you actually put it at the end of the table so all the Xml* attributes are grouped together?

@alundporchsoftware
Copy link
Contributor Author

@gewarren No problem, adjusted.

@gewarren gewarren enabled auto-merge (squash) March 29, 2024 21:14
@gewarren gewarren merged commit b63c640 into dotnet:main Mar 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete attribute missing from list of attributes that control XML Serialization
3 participants