Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for CA1872 #40180

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Add documentation for CA1872 #40180

merged 2 commits into from
Mar 22, 2024

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Mar 21, 2024 •
edited by github-actions bot
Loading

@mpidash mpidash requested review from gewarren and a team as code owners March 21, 2024 22:38
@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Mar 21, 2024
gewarren
gewarren requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great!

docs/fundamentals/code-analysis/quality-rules/performance-warnings.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/index.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1872.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1872.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1872.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1872.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1872.md Outdated Show resolved Hide resolved
@mpidash @gewarren
Apply suggestions from code review
2e63823 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren merged commit 55d4438 into dotnet:main Mar 22, 2024
8 checks passed
@gewarren
Copy link
Contributor

Thank you @mpidash!

@mpidash mpidash deleted the ca1872 branch March 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@mpidash @gewarren @dotnet-bot