Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix important alert in single file deployment #40160

Conversation

Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Mar 21, 2024

Summary

The important alert is missing the bang (!), causing it to be rendered as a regular blockquote. Added the bang.


Internal previews

📄 File 🔗 Preview link
docs/core/deploying/single-file/overview.md Single-file deployment

@Rageking8 Rageking8 requested a review from adegeo as a code owner March 21, 2024 11:07
@dotnet-bot dotnet-bot added this to the March 2024 milestone Mar 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Mar 21, 2024
@Rageking8
Copy link
Contributor Author

@BillWagner Hi, would it be possible for you to help merge this trivial PR? Thanks in advance.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Rageking8

I'll :shipit: now.

@BillWagner BillWagner merged commit f01f496 into dotnet:main Mar 29, 2024
11 checks passed
@Rageking8 Rageking8 deleted the fix-important-alert-in-single-file-deployment branch March 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants