Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More issue template updates #39371

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Feb 1, 2024

Fast follow to #39354.

Also renames to use numbers to order templates instead of letters.

@gewarren gewarren requested a review from a team as a code owner February 1, 2024 16:48
@dotnet-bot dotnet-bot added this to the February 2024 milestone Feb 1, 2024
@BillWagner
Copy link
Member

@gewarren

I like what's here, but you also need to change the name of the issue template in our docfx.json here

Otherwise, the feedback control won't work.

@gewarren
Copy link
Contributor Author

gewarren commented Feb 2, 2024

@gewarren

I like what's here, but you also need to change the name of the issue template in our docfx.json here

Otherwise, the feedback control won't work.

@BillWagner What do I need to update there? I didn't change the name of the z-customer-feedback.yml template.

@BillWagner
Copy link
Member

@BillWagner What do I need to update there? I didn't change the name of the z-customer-feedback.yml template.

You're right. I looked at the comment, but didn't notice that the first and last weren't renamed.

Approving.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's merge it.

@gewarren gewarren merged commit 7e8c9a7 into dotnet:main Feb 2, 2024
7 checks passed
@gewarren gewarren deleted the issue-templates2 branch February 2, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants