Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CA2262 #39351

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add CA2262 #39351

merged 2 commits into from
Feb 1, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 31, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner January 31, 2024 21:48
@gewarren gewarren requested a review from buyaa-n January 31, 2024 21:49
buyaa-n
buyaa-n approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thank you!

BillWagner
BillWagner approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren @buyaa-n
Update docs/fundamentals/code-analysis/quality-rules/ca2262.md
cfbc989 
Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
@gewarren gewarren merged commit 5235b31 into dotnet:main Feb 1, 2024
8 checks passed
@gewarren gewarren deleted the ca2262 branch February 1, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@buyaa-n buyaa-n buyaa-n approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document CA2262
4 participants
@gewarren @BillWagner @buyaa-n @dotnet-bot