Clarify the rules on UnmanagedCallersOnly #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elinor-fung @jkotas @jaredpar @AaronRobinsonMSFT for review. I've updated the rules for UnmanagedCallersOnly following discussion on the implementation of dotnet/roslyn#47008. |
333fred
requested review from
elinor-fung,
jkotas,
jaredpar and
AaronRobinsonMSFT
333fred
commented
Aug 25, 2020
333fred
commented
Aug 25, 2020
jkotas
approved these changes
Aug 25, 2020
jkotas
reviewed
Aug 25, 2020
|
@jkotas addressed feedback. |
jaredpar
reviewed
Aug 25, 2020
jkotas
reviewed
Aug 26, 2020
1. Simplify the parameter/return requirements. 2. Clarify the intent around invalid imported metadata.
jkotas
approved these changes
Aug 26, 2020
|
Lgtm |
AaronRobinsonMSFT
approved these changes
Aug 26, 2020
| * It is an error to apply the attribute to anything other than a static method. The C# compiler will mark any non-static | ||
| methods imported from metadata with this attribute as unsupported by the language. | ||
| * It is an error to have managed types as parameters or the return type of a method marked with the attribute. | ||
| * It is an error to apply the attribute to anything other than an ordinary static method or ordinary static local function. |
There was a problem hiding this comment.
Just wondering, but why are operators/properties restricted here? Is it just a language limitation, similar to binding against a signature that takes explicit this for instance methods?
There was a problem hiding this comment.
Correct, this is a language limitation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.