Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/3.1] Remove the use of dotnet-core #43100

Closed
wants to merge 1 commit into from

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Aug 13, 2021

No description provided.

@mmitche mmitche changed the title Remove the use of dotnet-core [release/3.1] Remove the use of dotnet-core Aug 13, 2021
@adamsitnik
Copy link
Member

FWIW I can repro locally the issue reported by the CI:

D:\projects\corefx\src\System.Windows.Extensions\tests\System.Windows.Extensions.Tests.csproj : error NU1101: Unable to find package System.Windows.Extensions.TestData. No packages exist with this id in source(s): dotnet-eng, dotnet-public, dotnet-tools, dotnet3, dotnet3.1, dotnet3.1-transport [D:\projects\corefx\src\tests.proj]

(I am trying to backport dotnet/runtime#57479 to 3.1 and can't build corefx)

@adamsitnik
Copy link
Member

The error no longer occurs, I can build the repo using the changes from this PR

@safern
Copy link
Member

safern commented Jan 11, 2022

@mmitche what's the status of this, should we merge?

@mmitche
Copy link
Member Author

mmitche commented Jan 11, 2022

@mmitche what's the status of this, should we merge?

It would be good to, but there needs to be investigation of the error. I assume it would break the official build.

@carlossanlop
Copy link
Member

@mmitche friendly ping in case you think we should take this change for the next servicing release. Deadline is Monday 03/14 (I'm assuming the same deadline applies to infra changes).

@mmitche
Copy link
Member Author

mmitche commented Apr 6, 2022

@carlossanlop Yeah we should take this for this servicing release.

@mmitche mmitche closed this Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants