Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[release/2.1] Don't close connection for responses to NT auth using 100continue #39341

Merged
merged 1 commit into from
Jul 16, 2019
Merged

[release/2.1] Don't close connection for responses to NT auth using 100continue #39341

merged 1 commit into from
Jul 16, 2019

Conversation

davidsh
Copy link
Contributor

@davidsh davidsh commented Jul 9, 2019

Port fix from PR #38744 (.NET Core 3.0) to release/2.1 LTS branch.

Fixes #30760

@davidsh
Don't close connection for responses to NT auth using 100continue
6d31d52 
Port fix from PR dotnet#38744 (.NET Core 3.0) to release/2.1 LTS branch.

Fixes #30760
@davidsh davidsh added tenet-compatibility Incompatibility with previous versions or .NET Framework blocking Marks issues that we want to fast track in order to unblock other important work area-System.Net.Http.SocketsHttpHandler labels Jul 9, 2019
@davidsh davidsh added this to the 2.1.x milestone Jul 9, 2019
@davidsh davidsh self-assigned this Jul 9, 2019
@davidsh
Copy link
Contributor Author

davidsh commented Jul 9, 2019 •
edited
Loading

Description

Sending an HTTP POST/PUT request with more than 1024 bytes to a server that uses Expect: 100-continue semantics and requires enterprise authentication will fail with an exception.

Customer Impact

This is blocking key scenarios for enterprise customers including WCF customers which reported this issue.

Regression?

Yes from .NET Core 2.0 (and .NET Framework) which didn't use SocketsHttpHandler.

Risk

Minimal.

@davidsh davidsh changed the title Don't close connection for responses to NT auth using 100continue [release/2.1] Don't close connection for responses to NT auth using 100continue Jul 9, 2019
@davidsh
Copy link
Contributor Author

davidsh commented Jul 9, 2019

cc: @mconnew @danmosemsft @karelz @stephentoub @wfurt

@davidsh
Copy link
Contributor Author

davidsh commented Jul 9, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidsh
Copy link
Contributor Author

davidsh commented Jul 9, 2019

@dotnet-bot test Outerloop Windows x64 Debug Build
@dotnet-bot test Outerloop Linux x64 Debug Build

@mconnew mconnew mentioned this pull request Jul 9, 2019
Closed
@davidsh
Copy link
Contributor Author

davidsh commented Jul 9, 2019

@dotnet-bot test Outerloop Windows x64 Debug Build

@davidsh
Copy link
Contributor Author

davidsh commented Jul 9, 2019

/azp run corefx-outerloop-windows

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@davidsh davidsh added the Servicing-consider Issue for next servicing release review label Jul 9, 2019
@StephenBonikowsky
Copy link
Member

@davidsh What's the status on this PR? Can it be merged?

@davidsh
Copy link
Contributor Author

davidsh commented Jul 16, 2019

@davidsh What's the status on this PR? Can it be merged?

It cannot be merged yet. It, along with other release/2.1 PRs are waiting for shiproom approval.

@StephenBonikowsky
Copy link
Member

Ok, thanks.

@vivmishra vivmishra added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 16, 2019
@vivmishra vivmishra modified the milestones: 2.1.x, 2.1.13 Jul 16, 2019
@vivmishra
Copy link

Approved for 2.1.13 and 2.2.7

@davidsh davidsh merged commit 470d787 into dotnet:release/2.1 Jul 16, 2019
@davidsh davidsh deleted the port_pr38744_21 branch July 16, 2019 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@davidsh davidsh

Labels
blocking Marks issues that we want to fast track in order to unblock other important work Servicing-approved Approved for servicing release tenet-compatibility Incompatibility with previous versions or .NET Framework
Projects
None yet
Milestone
2.1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsh @StephenBonikowsky @vivmishra