Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Consume Microsoft.DotNet.CoreFxTesting package #33423

Merged
merged 13 commits into from
Dec 6, 2018

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 12, 2018

Depends on dotnet/arcade#1318

Changes:

  • Consume Microsoft.DotNet.CoreFXTesting arcade package
  • *.Performance.Tests.csproj renamed to *.PerformanceTests.csproj
  • "Test support assemblies", assemblies which are not invoked by the test runner directly don't reference the whole testing framework and only get what they need.
  • Code coverage with coverlet

cc @weshaggard @ericstj @safern @danmosemsft @wtgodbe

Directory.Build.props Outdated Show resolved Hide resolved
Directory.Build.props Show resolved Hide resolved
external/test-runtime/XUnit.Runtime.depproj Outdated Show resolved Hide resolved
external/test-runtime/XUnit.Runtime.depproj Show resolved Hide resolved
Directory.Build.props Outdated Show resolved Hide resolved
@ViktorHofer ViktorHofer force-pushed the CoreFxTesting branch 7 times, most recently from 24cc442 to 7717ac2 Compare November 30, 2018 02:10
Directory.Build.props Outdated Show resolved Hide resolved
@ViktorHofer ViktorHofer changed the title [WIP] Consume Microsoft.DotNet.CoreFxTesting package Consume Microsoft.DotNet.CoreFxTesting package Dec 3, 2018
@ViktorHofer ViktorHofer force-pushed the CoreFxTesting branch 2 times, most recently from 64187cd to 851c4bb Compare December 4, 2018 00:15
@ViktorHofer ViktorHofer self-assigned this Dec 4, 2018
eng/Versions.props Outdated Show resolved Hide resolved
@ViktorHofer
Copy link
Member Author

@safern @ericstj PTAL

@ViktorHofer ViktorHofer force-pushed the CoreFxTesting branch 2 times, most recently from 6c3e43b to 5477b42 Compare December 4, 2018 20:19
@ViktorHofer
Copy link
Member Author

test code coverage

@ViktorHofer
Copy link
Member Author

@mmitche I'm changing the location of the coverage report dir in this PR. How can we change the htmlpublisher to now point to corefx/artifacts/coverage instead of corefx/artifacts/bin/tests/coverage? Thanks

@mmitche
Copy link
Member

mmitche commented Dec 5, 2018

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Dec 5, 2018

@mmitche I changed that with commit 84fd227 yesterday but I believe the path wasn't picked up. Let me try it again.

@ViktorHofer
Copy link
Member Author

test code coverage

@ViktorHofer
Copy link
Member Author

@mmitche the path isn't being picked up correctly: 12:05:31 ERROR: Specified HTML directory 'D:\j\workspace\code_coverage---d5838fef\artifacts\bin\tests\coverage' does not exist. (https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows_prtest/79/console)

@ViktorHofer
Copy link
Member Author

@dotnet-bot test Windows x64 Debug Build

@safern
Copy link
Member

safern commented Dec 5, 2018

@mmitche the path isn't being picked up correctly: 12:05:31 ERROR: Specified HTML directory 'D:\j\workspace\code_coverage---d5838fef\artifacts\bin\tests\coverage' does not exist.

From what I know, anything under netci.groovy will not take effect until it is merged, so the builds coming from netci.groovy in this PR come from the file in master branch rather than your PR branch.

@ViktorHofer
Copy link
Member Author

Awesome, that explains the error. Thanks

@mmitche
Copy link
Member

mmitche commented Dec 5, 2018

Yes that is correct.

@ViktorHofer
Copy link
Member Author

test Packaging All Configurations x64 Debug Build

@ViktorHofer
Copy link
Member Author

test UWP NETNative x86 Release Build
test Windows x64 Debug Build

@ViktorHofer
Copy link
Member Author

test UWP NETNative x86 Release Build

@ViktorHofer ViktorHofer merged commit ae38b7c into dotnet:master Dec 6, 2018
@ViktorHofer ViktorHofer deleted the CoreFxTesting branch December 6, 2018 01:56
@safern
Copy link
Member

safern commented Dec 6, 2018

I'm seeing the following warning in the logs for OSX and Linux builds:

19:22:00 EXEC : warning NU1101: Unable to find package coverlet.console. No packages exist with this id in source(s): /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/.dotnet/sdk/NuGetFallbackFolder, dotnet-core [/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/.packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.18603.8/tools/Tools.proj]
19:22:00   The tool package could not be restored.
19:22:00   Tool 'coverlet.console' failed to install. This failure may have been caused by:
19:22:00   
19:22:00   * You are attempting to install a preview release and did not use the --version option to specify the version.
19:22:00   * A package by this name was found, but it was not a .NET Core tool.
19:22:00   * The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
19:22:00   * You mistyped the name of the tool.
19:22:00 /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/eng/Tools.props(90,5): warning MSB3073: The command "/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/.dotnet/dotnet tool install --tool-path /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/artifacts/tools/ coverlet.console --version 1.3.0" exited with code 1. [/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/.packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.18603.8/tools/Tools.proj]
19:22:00 EXEC : warning NU1101: Unable to find package dotnet-reportgenerator-globaltool. No packages exist with this id in source(s): /Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/.dotnet/sdk/NuGetFallbackFolder, dotnet-core [/Users/dotnet-bot/j/workspace/dotnet_corefx/master/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/.packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.18603.8/tools/Tools.proj]
19:22:00   The tool package could not be restored.
19:22:00   Tool 'dotnet-reportgenerator-globaltool' failed to install. This failure may have been caused by:
19:22:00   
19:22:00   * You are attempting to install a preview release and did not use the --version option to specify the version.
19:22:00   * A package by this name was found, but it was not a .NET Core tool.
19:22:00   * The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
19:22:00   * You mistyped the name of the tool.

Is this expected? Should we condition the command to windows for now?

@ViktorHofer
Copy link
Member Author

I'll investigate now. That's unexpected

@ericstj
Copy link
Member

ericstj commented Dec 6, 2018

Remember that this won't be using our nuget.config from the root of the repo since the project being restored is in the arcade sdk package. OSX and Linux likely won't have machine-wide nuget.config, so you may need to add sources into tools.props.

jlennox pushed a commit to jlennox/corefx that referenced this pull request Dec 16, 2018
* Consume Microsoft.DotNet.CoreFxTesting package

* Remove code coverage dedicated runtime dir config files and switch to Coverlet

* Add global tool support in corefx

* Update code coverage docs
@karelz karelz added this to the 3.0 milestone Dec 21, 2018
macrogreg pushed a commit to open-telemetry/opentelemetry-dotnet-instrumentation that referenced this pull request Sep 24, 2020
* Consume Microsoft.DotNet.CoreFxTesting package

* Remove code coverage dedicated runtime dir config files and switch to Coverlet

* Add global tool support in corefx

* Update code coverage docs

Commit migrated from dotnet/corefx@ae38b7c
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Consume Microsoft.DotNet.CoreFxTesting package

* Remove code coverage dedicated runtime dir config files and switch to Coverlet

* Add global tool support in corefx

* Update code coverage docs

Commit migrated from dotnet/corefx@ae38b7c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants