This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix several WebSocket tests blocking xunit's SynchronizationContext #32591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
changed the title
davidsh
reviewed
Oct 3, 2018
| @@ -12,6 +12,19 @@ namespace System.Threading.Tasks | |||
| { | |||
| public static class TaskTimeoutExtensions | |||
| { | |||
| public static async Task WithCancellation( this Task task, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
nit: remove space before "this Task task"
davidsh
approved these changes
Oct 3, 2018
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/corefx#32591) * Fix several WebSocket tests that were blocking xunit's SynchronizationContext * Address PR feedback Commit migrated from dotnet/corefx@7685f1c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/32589
cc: @wfurt, @davidsh