Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Disable JIT/Directed/pinvoke/pinvoke-examples test. #27614

Merged
merged 3 commits into from
Nov 1, 2019

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Nov 1, 2019

Fixes #27602

/cc @benaadams @echesakovMSFT

@AaronRobinsonMSFT AaronRobinsonMSFT added area-CodeGen disabled-test The test is disabled in source code against the issue labels Nov 1, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 5.0 milestone Nov 1, 2019
Copy link

@echesakov echesakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AaronRobinsonMSFT
Copy link
Member Author

@AndyAyersMS Can you please review the test I fixed. I followed the guidance provided in #27543 (comment) to use a PInvoke that returns a constant.

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit cceb5c8 into dotnet:master Nov 1, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the coreclr_27602 branch November 1, 2019 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failed: JIT\Directed\pinvoke\pinvoke-examples\pinvoke-examples.cmd
4 participants