Commits on Oct 28, 2019

1. Support large EventSource filter args …

   1. Fix NullReferenceException. When the filter args exceeded the
   hard-coded size limit GetDataFromController would return data = null.
   The code previously asserted that data was not null and triggered NRE
   when it was. The fix correctly null checks the value instead of
   asserting and uses an empty args dictionary in this case, the same as if
   filter args had been empty to begin with.
   
   2. ETW has always limited filter args to 1024 bytes but EventPipe has no
   such restriction. When using DiagnosticSourceEventSource it can be
   useful to specify a larger filter arg blob. I can't do anything about
   ETW's restriction but there is no need for the runtime to force
   EventPipe to be equally limited. The larger size also reduces the chance
   that we need to hit the fallback path above causing filter args to be
   ignored.

   

   noahfalk committed Oct 28, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 131412c
   • Browse repository at this point

   Copy the full SHA

   131412c View commit details

   Browse the repository at this point in the history