Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add a regression test for #13160 #13531

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Conversation

parjong
Copy link

@parjong parjong commented Aug 22, 2017

No description provided.

@parjong
Copy link
Author

parjong commented Aug 22, 2017

D:\j\workspace\x64_release_w---0575cb46\bin\tests\Windows_NT.x64.Release\TestWrappers\JIT.jit64\JIT.jit64.XUnitWrapper.cs(28597): error : JIT_jit64._opt_cse_VolatileTest_op_add_VolatileTest_op_add_._opt_cse_VolatileTest_op_add_VolatileTest_op_add_cmd [FAIL] [D:\j\workspace\x64_release_w---0575cb46\tests\runtest.proj]
08:35:34         
08:35:34   
08:35:34   Return code:      1
08:35:34   Raw output file:      D:\j\workspace\x64_release_w---0575cb46\bin\tests\Windows_NT.x64.Release\Reports\JIT.jit64\opt\cse\VolatileTest_op_add\VolatileTest_op_add.output.txt
08:35:34   Raw output:
08:35:34   BEGIN EXECUTION
08:35:34          "D:\j\workspace\x64_release_w---0575cb46\tests\..\bin\tests\Windows_NT.x64.Release\Tests\Core_Root\corerun.exe" VolatileTest_op_add.exe 
08:35:34         this test is designed to hang if jit cse doesnt honor volatile
08:35:34         Test 1 passed after 8332906 tries
08:35:34         Test 2 passed after 138 tries
08:35:34         Test 3 passed after 235 tries
08:35:34         Expected: 100
08:35:34         Actual: -1073740791
08:35:34         END EXECUTION - FAILED
08:35:34         FAILED
08:35:34         Test Harness Exitcode is : 1

@parjong
Copy link
Author

parjong commented Aug 22, 2017

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please

@parjong parjong changed the title Add a test for #13160 Add a regression test for #13160 Aug 23, 2017
@parjong
Copy link
Author

parjong commented Aug 23, 2017

@dotnet-bot test Tizen armel Cross Debug Build please

Action d1 = p.VirtualMethod;
Action d2 = p.VirtualMethod;

if (d1.Equals(d2))
Copy link
Member

@jkotas jkotas Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d1 should be equal d2 as well here. Why not enforce it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though that that equality may not hold. I'll updated PR.

@parjong
Copy link
Author

parjong commented Aug 23, 2017

@dotnet-bot test Tizen armel Cross Debug Build please

@jkotas
Copy link
Member

jkotas commented Aug 23, 2017

Thanks

@jkotas jkotas merged commit f46134f into dotnet:master Aug 23, 2017
@parjong parjong deleted the fix/Add_Github13160_Test branch August 23, 2017 22:20
@karelz karelz modified the milestone: 2.1.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants