[release/8.0] Preserve RemoteAuthenticationContext during trimming if used in JS interop #54655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
added
the
Servicing-consider
dotnet-issue-labeler
bot
added
the
area-blazor
halter73
changed the title
rbhanda
added
Servicing-approved
mkArtakMSFT
approved these changes
Mar 25, 2024
dotnet-policy-service
bot
added
the
pending-ci-rerun
wtgodbe
removed
the
pending-ci-rerun
1 task
oskogstad
added a commit
to digdir/dialogporten
that referenced
this pull request
May 26, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.AspNetCore.Authentication.JwtBearer](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Mvc.NewtonsoftJson](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.OpenApi](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.EntityFrameworkCore.Relational](https://docs.microsoft.com/ef/core/) ([source](https://togithub.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.EntityFrameworkCore.Tools](https://docs.microsoft.com/ef/core/) ([source](https://togithub.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.Extensions.Caching.StackExchangeRedis](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.Extensions.Http.Polly](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/aspnetcore (Microsoft.AspNetCore.Authentication.JwtBearer)</summary> ### [`v8.0.5`](https://togithub.com/dotnet/aspnetcore/releases/tag/v8.0.5): .NET 8.0.5 [Release](https://togithub.com/dotnet/core/releases/tag/v8.0.5) ##### What's Changed - \[release/8.0] Update dependencies from dotnet/source-build-externals by [@​dotnet-maestro](https://togithub.com/dotnet-maestro) in [dotnet/aspnetcore#54744 - Update branding to 8.0.5 by [@​vseanreesermsft](https://togithub.com/vseanreesermsft) in [dotnet/aspnetcore#54907 - \[release/8.0] Convert to 1ES templates by [@​RussKie](https://togithub.com/RussKie) in [dotnet/aspnetcore#54660 - Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton by [@​Eilon](https://togithub.com/Eilon) in [dotnet/aspnetcore#54608 - \[release/8.0] (deps): Bump src/submodules/googletest from `31993df` to `77afe8e` by [@​dependabot](https://togithub.com/dependabot) in [dotnet/aspnetcore#54872 - \[release/8.0] Reduce helix-matrix timeout to 5 hours by [@​github-actions](https://togithub.com/github-actions) in [dotnet/aspnetcore#54778 - \[release/8.0] Preserve RemoteAuthenticationContext during trimming if used in JS interop by [@​halter73](https://togithub.com/halter73) in [dotnet/aspnetcore#54655 - \[release/8.0] Improve usage of `Type.GetType` when activating types in data protection by [@​github-actions](https://togithub.com/github-actions) in [dotnet/aspnetcore#54762 - \[release/8.0] Fix route analyzer performance with highly concatenated strings by [@​github-actions](https://togithub.com/github-actions) in [dotnet/aspnetcore#54763 - \[release/8.0] Suppress .ps1 SDL errors by [@​wtgodbe](https://togithub.com/wtgodbe) in [dotnet/aspnetcore#54915 - \[release/8.0] Backport test fixes by [@​MackinnonBuck](https://togithub.com/MackinnonBuck) in [dotnet/aspnetcore#54912 - \[release/8.0] Skip SpotBugs for now by [@​wtgodbe](https://togithub.com/wtgodbe) in [dotnet/aspnetcore#54952 - Merging internal commits for release/8.0 by [@​vseanreesermsft](https://togithub.com/vseanreesermsft) in [dotnet/aspnetcore#55034 - \[release/8.0] Update dependencies from dotnet/arcade by [@​dotnet-maestro](https://togithub.com/dotnet-maestro) in [dotnet/aspnetcore#55061 - \[release/8.0] Update Wix version by [@​github-actions](https://togithub.com/github-actions) in [dotnet/aspnetcore#55101 **Full Changelog**: dotnet/aspnetcore@v8.0.4...v8.0.5 </details> <details> <summary>dotnet/efcore (Microsoft.EntityFrameworkCore.Relational)</summary> ### [`v8.0.5`](https://togithub.com/dotnet/efcore/releases/tag/v8.0.5): EF Core 8.0.5 This is a [patch release of EF Core 8.0](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/8.0.5) containing only updates to dependencies. There are no additional fixes in this release beyond those already shipped in EF Core 8.0.4. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am on Wednesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/digdir/dialogporten). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
](https://renovatebot.com){kind=link}
halter73
added a commit
to halter73/AspNetCore
that referenced
this pull request
Jun 18, 2024
- This fixes a regression introduced by dotnet#54655
halter73
added a commit
to halter73/AspNetCore
that referenced
this pull request
Jun 18, 2024
- This fixes a regression introduced by dotnet#54655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54225 to release/8.0
Description
Preserve
RemoteAuthenticationContextfrom Microsoft.AspNetCore.Components.WebAssembly.Authentication during trimming if used in JS interop in order to avoid errors during sign in and sign out.Fixes #49956 and other customer-reported issues. See original PR for full list.
Customer Impact
With certain non-default, but common configurations, over trimming can cause Blazor WASM AAD authentication to show 'There was an error trying to log you in: '"undefined" is not valid JSON' despite the login succeeding.
This can also cause the final redirect to fail after logging out causing the user to get stuck "Processing logout callback..." instead of redirecting back to the previous page.
The over trimming also prevents "extraQueryParams" from being sent to the OIDC provider as reported in #53409.
Regression?
Risk
This change is thoroughly tested and simply preserves more necessary members during trimming of the Microsoft.AspNetCore.Components.WebAssembly.Authentication assembly.
Verification
Packaging changes reviewed?