Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add VS.Redist project for ANCM #44459

Merged
merged 1 commit into from
Oct 11, 2022
Merged

[release/6.0] Add VS.Redist project for ANCM #44459

merged 1 commit into from
Oct 11, 2022

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Oct 10, 2022

Generate VS.Redist package for ANCM

Adds VS.Redist package that allows auto-insertion of ANCM into Visual Studio

Description

Adds nonshipping VS.Redist package that allows auto-insertion of ANCM into Visual Studio. Will need a follow-up change in VS, and possibly the release pipeline.

Customer Impact

Makes it less likely we miss updating VS in ANCM when there's a security fix

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

Doesn't change code, just adds a nonshipping package

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@wtgodbe wtgodbe requested a review from a team October 10, 2022 23:07
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 10, 2022
@ghost ghost added this to the 6.0.x milestone Oct 10, 2022
@ghost
Copy link

ghost commented Oct 10, 2022

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@wtgodbe wtgodbe added the Servicing-consider Shiproom approval is required for the issue label Oct 10, 2022
@ghost
Copy link

ghost commented Oct 10, 2022

Hi @wtgodbe. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Oct 11, 2022
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.11 Oct 11, 2022
@wtgodbe wtgodbe merged commit 1133531 into dotnet:release/6.0 Oct 11, 2022
@wtgodbe wtgodbe deleted the wtgodbe/Redist branch October 11, 2022 18:42
@wtgodbe wtgodbe restored the wtgodbe/Redist branch November 15, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants