Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up Blazor ILLink Descriptor files #23313

Closed
wants to merge 0 commits into from
Closed

Fix up Blazor ILLink Descriptor files #23313

wants to merge 0 commits into from

Conversation

eerhardt
Copy link
Member

  1. Add the typegranularity file to TrimmerRootDescriptor.
  2. Remove the application assembly descriptor file, since the application assembly is passed in as a RootAssembly already.

cc @sbomer @vitek-karas

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 24, 2020
@pranavkm pranavkm changed the base branch from master to release/5.0-preview7 June 24, 2020 17:00
@eerhardt eerhardt added area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jun 24, 2020
@sbomer
Copy link
Member

sbomer commented Jun 24, 2020

Is the intention for the intermediate assembly to remain !IsTrimmable? If so this looks good to me. If we are going to set TrimMode (described in dotnet/sdk#12035 (comment)) to link and enable trimming of IntermediateAssembly, this would result in only the entry point getting rooted for that assembly (see https://github.com/mono/linker/blob/master/src/linker/Linker.Steps/ResolveFromAssemblyStep.cs#L161).

@pranavkm
Copy link
Contributor

s the intention for the intermediate assembly to remain !IsTrimmable?

Yup, we do not want to trim the app's assembly or any references outside of AspNetCore assemblies.

@pranavkm pranavkm changed the base branch from release/5.0-preview7 to master June 24, 2020 17:31
@pranavkm pranavkm mentioned this pull request Jun 24, 2020
Merged
@eerhardt eerhardt closed this Jun 26, 2020
@eerhardt eerhardt deleted the ReworkBlazorLinker branch June 26, 2020 16:00
@eerhardt
Copy link
Member Author

These changes were taken in #23317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm Awaiting requested review from pranavkm

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eerhardt @sbomer @pranavkm