Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Async to server library #22575

Merged
merged 42 commits into from
Sep 17, 2020
Merged

Update Async to server library #22575

merged 42 commits into from
Sep 17, 2020

Conversation

hueifeng
Copy link
Contributor

@hueifeng hueifeng commented Jun 5, 2020

Modify some methods to be asynchronous.

@ghost ghost added the area-servers label Jun 5, 2020
@shirhatti shirhatti added this to the Next sprint planning milestone Jun 5, 2020
@shirhatti
Copy link
Contributor

Solves #12334

@halter73
Copy link
Member

This at least partially solves #12334. There are more places we call Complete() outside of an async context which will likely be trickier to fix.

@hueifeng
Copy link
Contributor Author

@halter73 I have modified some of the others. I am not sure whether we should keep both synchronous and asynchronous methods. I found that Abort is a synchronous method, and I am not sure whether to change it to asynchronous?

@halter73
Copy link
Member

halter73 commented Jun 11, 2020

@hueifeng Thanks for working on this issues. I made my last comment about there being other calls to Complete() just so we don't prematurely close #12334. I wasn't asking you to address everything. I was going to merge your PR as it was.

It looks like you're on the right track though. If it gets too messy, I might just take the initial commit.

@halter73 I have modified some of the others. I am not sure whether we should keep both synchronous and asynchronous methods. I found that Abort is a synchronous method, and I am not sure whether to change it to asynchronous?

For internal interfaces and types, it's OK to get rid of the synchronous methods if they're not called.

@pranavkm
Copy link
Contributor

Bad rebase?

@halter73 halter73 merged commit 1cb3f23 into dotnet:master Sep 17, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants