Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit suppression of CA1305 in .editorconfig #34361

Closed
DamianEdwards opened this issue Jul 15, 2021 · 1 comment · Fixed by #35867
Closed

Revisit suppression of CA1305 in .editorconfig #34361

DamianEdwards opened this issue Jul 15, 2021 · 1 comment · Fixed by #35867
Assignees
@pranavkm
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Milestone
6.0-rc2

Comments

@DamianEdwards
Copy link
Member

Latest preview.7 SDK introduced new C# language features including interpolated string builders, along with which comes new warning cases for CA1305. That warning has been configured as a suggestion in .editorconfig for now to unblock the build and should be revisited to ensure all cases are appropriately adjusted.
@DamianEdwards DamianEdwards added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 15, 2021
@DamianEdwards DamianEdwards added this to the 6.0-rc1 milestone Jul 15, 2021
@DamianEdwards
Copy link
Member Author

@pranavkm @dotnet/aspnet-build

DamianEdwards added a commit that referenced this issue Jul 15, 2021
@DamianEdwards
Update templates to use file scoped namespace declarations (#34220)
25767de 
* Update templates to use file-scoped namespace declarations
* Move to SDK version that supports file-scoped namespaces
* Make CA1305 a suggestion rather than error
  - New compiler now makes this appear when using a StringBuilder with string interpolation. Logged #34361 to follow up.

Contributes to #33947
@pranavkm pranavkm modified the milestones: 6.0-rc1, 6.0-rc2 Aug 26, 2021
@pranavkm pranavkm self-assigned this Aug 26, 2021
@pranavkm pranavkm mentioned this issue Aug 27, 2021
Merged
pranavkm added a commit that referenced this issue Aug 27, 2021
@pranavkm
Re-enable CA1305
8644b58 
Fixes #34361
@ghost ghost added the Working label Aug 27, 2021
pranavkm added a commit that referenced this issue Aug 28, 2021
@pranavkm
Re-enable CA1305 (#35867)
e3230e5 
* Re-enable CA1305
Fixes #34361
@ghost ghost added Done This issue has been fixed and removed Working labels Aug 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
3dots pushed a commit to 3dots/aspnetcore-Web.JS that referenced this issue Feb 19, 2024
@pranavkm
Re-enable CA1305 (#35867)
6458d12 
* Re-enable CA1305
Fixes dotnet/aspnetcore#34361
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Milestone
6.0-rc2
Development

Successfully merging a pull request may close this issue.

Re-enable CA1305 dotnet/aspnetcore
2 participants
@pranavkm @DamianEdwards