Avoid unnecessary HealthStatus comparison (#58176)

It's only necessary to check `currentValue == HealthStatus.Unhealthy` when `currentValue` changes. During the first iteration, it is known to be `Healthy`.
dotnet · Oct 3, 2024 · 3bc8d5b · 3bc8d5b
1 parent 38c1d3a
commit 3bc8d5b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/HealthChecks/Abstractions/src/HealthReport.cs b/src/HealthChecks/Abstractions/src/HealthReport.cs
@@ -66,13 +66,13 @@ private static HealthStatus CalculateAggregateStatus(IEnumerable<HealthReportEnt
             if (currentValue > entry.Status)
             {
                 currentValue = entry.Status;
-            }
 
-            if (currentValue == HealthStatus.Unhealthy)
-            {
-                // Game over, man! Game over!
-                // (We hit the worst possible status, so there's no need to keep iterating)
-                return currentValue;
+                if (currentValue == HealthStatus.Unhealthy)
+                {
+                    // Game over, man! Game over!
+                    // (We hit the worst possible status, so there's no need to keep iterating)
+                    return currentValue;
+                }
             }
         }