Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden Helix SDK against Azure Storage Blobs bug #11364

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Oct 21, 2022

Addresses #11056.

Makes failure to call BlobClient.Exists() warn instead of throw for a known error mode. In most cases this exception was not fatal; this only impacts users who upload the same output path multiple times in a helix job and in a vast majority of such cases the first upload does succeed.

To double check:

…error mode. In most cases this exception was not fatal; this only impacts users who upload the same output path multiple times in a helix job and in a vast majority of such cases the first upload does succeed.
Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants