[Xamarin.Android.Build.Tasks] fix $(DestinationSubDirectory) double slash
#9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… slash
I noticed in a `.binlog` in .NET 9:
ProcessAssemblies
...
OutputItems
...
D:\.nuget\packages\microsoft.maui.controls.core\9.0.0-preview.7.24407.4\lib\net9.0-android35.0\ar\Microsoft.Maui.Controls.resources.dll
DestinationSubDirectory = arm64-v8a\ar\\
I believe this causes an issue, later down the line:
FastDeploy
...
Remove redundant file files/.__override__/arm64-v8a/ar/Microsoft.Maui.Controls.resources.dll
So, `<FastDeploy/>` seems to delete every `Microsoft.Maui.Controls.resources.dll`
file, because it is passed in:
obj\Debug\net9.0-android\android\assets\arm64-v8a\ar\Microsoft.Maui.Controls.resources.dll
TargetPath = arm64-v8a\ar\\Microsoft.Maui.Controls.resources.dll
I think this was introduced in 86260ed, we can fix it by only
appending to `%(DestinationSubDirectory)` if it *doesn't* end with a
`DirectorySeparatorChar`.
There may be additional safety we could add to the `<FastDeploy/>` task,
in a separate PR.
To test this going forward, I'm going to review our MSBuild performance
tests, and see if we can adjust the timings there.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Aug 9, 2024
This is testing what the current times are. I'll rework this, after some of the current build performance fixes make it in: * xamarin/monodroid#1535 * dotnet#9186
dellis1972
approved these changes
Aug 9, 2024
|
Hmm, this change must have brought some other bugs to the surface: I wonder if files were in |
I think they should now be in abi subdirectories. |
dellis1972
approved these changes
Aug 12, 2024
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Aug 20, 2024
This is testing what the current times are. I'll rework this, after some of the current build performance fixes make it in: * xamarin/monodroid#1535 * dotnet#9186
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in a
.binlogin .NET 9:I believe this causes an issue, later down the line:
So,
<FastDeploy/>seems to delete everyMicrosoft.Maui.Controls.resources.dllfile, because it is passed in:I think this was introduced in 86260ed, we can fix it by only appending to
%(DestinationSubDirectory)if it doesn't end with aDirectorySeparatorChar.There may be additional safety we could add to the
<FastDeploy/>task, in a separate PR.To test this going forward, I'm going to review our MSBuild performance tests, and see if we can adjust the timings there.