Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0.2xx] [tests] fix InvalidTargetPlatformVersion for net8.0 #9110

Merged

Conversation

jonathanpeppers
Copy link
Member

When 60dbcc9 was backported to .NET 8, the accompanying unit test was accidentally targeting .NET 9.

When 60dbcc9 was backported to .NET 8, the accompanying unit test was accidentally targeting .NET 9.
@jonathanpeppers
Copy link
Member Author

I don't see Rolf's changes from dotnet/sdk@25b360d in this file:

/mnt/vss/_work/1/s/bin/Release/dotnet/sdk/8.0.204/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets

This causes the InvalidTargetPlatformVersion("android32") test to fail.

So, let me see if this starts working from a newer .NET SDK.

@jonathanpeppers
Copy link
Member Author

Ok, I don't see that change in .NET 8 at all:

So, I guess we just remove part of this test.

@jonathanpeppers
Copy link
Member Author

There are some random/flaky failures for ApplicationRunsWithDebuggerAndBreaks, but I'm going to merge so this gets us close to green.

@jonathanpeppers jonathanpeppers merged commit a0518a1 into release/8.0.2xx Jul 16, 2024
44 of 47 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/peppers/InvalidTargetPlatformVersion branch July 16, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants