Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono.Android] Add properties for all documented AndroidManifest.xml attributes to [Activity], [Application], etc. #9096

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jul 10, 2024

Fixes: #9092

Previously, we created a process for automatically determining the possible attributes for elements in AndroidManifest.xml and generating the Mono.Android [Application], [Activity], etc. attributes for users to consume. At the time, we merely created the process, but did not use it to expose any new attributes that have been added in previous Android API levels that we never exposed.

This commit exposes all Google-documented manifest attributes for the elements we support. The undocumented manifest attributes were moved around in the file to a section denoted as "undocumented".

…attributes to `[Activity]`, `[Application]`, etc attributes.
@jpobst jpobst marked this pull request as ready for review July 11, 2024 17:35
@jonpryor jonpryor merged commit 328b6ed into main Aug 5, 2024
56 of 58 checks passed
@jonpryor jonpryor deleted the manifest-properties branch August 5, 2024 20:02
jonathanpeppers pushed a commit that referenced this pull request Aug 6, 2024
…9096)

Fixes: #9092

Context: 3ab74db

Previously in commit 3ab74db, we created a process for automatically
determining the possible attributes for elements in
`AndroidManifest.xml` and generating the `[Application]`, `[Activity]`,
etc. attributes within `Mono.Android.dll` for users to consume.  At the
time, we merely created the process, but did not use it to expose any
new attributes that have been added in previous Android API levels that
we never exposed.

This commit exposes all Google-documented manifest attributes for the
elements we support.  The undocumented manifest attributes were moved
around in the file to a section denoted as "undocumented".
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AndroidManifest.xml] Determine which attributes to expose in Mono.Android.
4 participants