Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing androidx.window.[extensions|sidecar] warnings #9085

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Missing androidx.window.[extensions|sidecar] warnings #9085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Xamarin.Android.Build.Tasks/Tasks/ReadAndroidManifest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,15 @@ public override bool RunTask ()
foreach (var uses_library in app.Elements ("uses-library")) {
var attribute = uses_library.Attribute (androidNs + "name");
if (attribute != null && !string.IsNullOrEmpty (attribute.Value)) {
var required = uses_library.Attribute (androidNs + "required")?.Value;
var path = Path.Combine (AndroidSdkDirectory, "platforms", $"android-{AndroidApiLevel}", "optional", $"{attribute.Value}.jar");
if (File.Exists (path)) {
libraries.Add (new TaskItem (path));
} else {
Log.LogWarningForXmlNode ("XA4218", ManifestFile, attribute, Properties.Resources.XA4218, path);
if (!bool.TryParse (required, out bool isRequired))
isRequired = true;
if (isRequired)
dellis1972 marked this conversation as resolved.
Show resolved Hide resolved
Log.LogWarningForXmlNode ("XA4218", ManifestFile, attribute, Properties.Resources.XA4218, path);
}
}
}
Expand Down
Loading