[xaprepare] skip download progress for dotnet-install script
#9053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are getting the error pretty early on during the build:
Downloading dotnet-install script...
Warning: Failed to obtain dotnet-install script size from URL 'https://dot.net/v1/dotnet-install.sh'. HTTP status code: InternalServerError (500)
-> https://dot.net/v1/dotnet-install.sh
downloading dotnet-install.sh
Trying a URL that will require less redirects.
This reverts commit 23db6f5.
Just download the dotnet-install script directly with no progress indication
jonathanpeppers
changed the title
dotnet-install script
pjcollins
approved these changes
Jun 25, 2024
jonathanpeppers
added a commit
that referenced
this pull request
Jun 25, 2024
We are getting the error pretty early on during the build:
Downloading dotnet-install script...
Warning: Failed to obtain dotnet-install script size from URL 'https://dot.net/v1/dotnet-install.sh'. HTTP status code: InternalServerError (500)a
-> https://dot.net/v1/dotnet-install.sh
downloading dotnet-install.sh
It seems the code is timing out on the call:
await httpClient.GetAsync (url, HttpCompletionOption.ResponseHeadersRead);
And then the code has some retry logic that eventually returns:
return (false, 0, HttpStatusCode.InternalServerError);
I am unable to reproduce this locally on either Mac or Windows.
Reworking this code to just download the file with no progress appears
to solve the problem on Azure DevOps build agents.
grendello
added a commit
that referenced
this pull request
Jun 27, 2024
* main: Bump to dotnet/android-tools@9674590 (#9036) Bump to dotnet/android-libzipsharp@de57dccb (#9010) [Xamarin.Android.Build.Tasks] Support VS "Build Acceleration" (#9042) Bump to dotnet/sdk@ea9243f9cb 9.0.100-preview.7.24323.5 (#9031) Fix places still pointing to xamarin/xamarin-android (#9050) [xaprepare] skip download progress for `dotnet-install` script (#9053) $(AndroidPackVersionSuffix)=preview.7; net9 is 34.99.0.preview.7 (#9052)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting the error pretty early on during the build:
It seems the code is timing out on the call:
And then the code has some retry logic that eventually returns:
I am unable to reproduce this locally on either Mac or Windows.
Reworking this code to just download the file with no progress appears to solve the problem on Azure DevOps build agents?