Commits on May 15, 2024

1. [build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.2… …

   …4262.2
   
   Context: dotnet/installer#19707
   Changes: dotnet/installer@fa261b9...1741345
   Changes: dotnet/runtime@4326eb7...84b3339
   Changes: dotnet/cecil@4abe3e6...7a4a59f
   
   dotnet/installer is no longer producing a
   `Microsoft.Dotnet.Sdk.Internal` "package" for the SDK. This is causing
   the maestro code-flow to fail, such as:
   
       > darc update-dependencies --id 225276
       Looking up build with BAR id 225276
       Checking for coherency updates...
       Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made.
       Found no dependencies to update.
   
   We use `Microsoft.Dotnet.Sdk.Internal` to provision the .NET SDK,
   similar to:
   
       ./dotnet-install.sh --version $(MicrosoftDotnetSdkInternalPackageVersion)
   
   Where `eng/Versions.props` is updated by the Maestro bot for the
   version number.
   
   Looking for the `Microsoft.Dotnet.Sdk.Internal` dependency, such as:
   
       > darc gather-drop --id 225276 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal
       Root build - Build number 20240512.2 of
       https://dev.azure.com/dnceng/internal/_git/dotnet-installer
       @ 1741345c6399ae203d8f259fb12fb873dac5129d
   
   But we can find the package for .NET 9 Preview 4:
   
       > darc gather-drop --id 225611 -o drop --dry-run | grep Microsoft.Dotnet.Sdk.Internal
       Root build - Build number 20240515.4 of
       https://dev.azure.com/dnceng/internal/_git/dotnet-installer
       @ df80b5eb607242b1d8ded158ec97a25e5d5e5e05
       Skipping non-shipping asset Microsoft.Dotnet.Sdk.Internal@9.0.100-preview.4.24265.4
   
   For now, we can use `VS.Tools.Net.Core.SDK.Resolver` instead, as
   this is a component inserted into Visual Studio that contains the same
   version number.
   
   We may have to change this again in the future, as dotnet/installer is
   in the process of merging and/or moving to dotnet/sdk.
   
   MS employees can see more details in the [MS Teams thread][0].
   
   [0]: https://teams.microsoft.com/l/message/19:afba3d1545dd45d7b79f34c1821f6055@thread.skype/1715789991637?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1715789991637&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1715789991637

   

   jonathanpeppers committed May 15, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5e3ba2b
   • Browse repository at this point

   Copy the full SHA

   5e3ba2b View commit details

   Browse the repository at this point in the history