Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft.Android.Templates] Add icons to templates #8883

Merged
merged 3 commits into from
May 16, 2024

Conversation

jonpryor
Copy link
Member

@jpobst
Copy link
Contributor

jpobst commented Apr 19, 2024

It looks like (recently?) the Classic Xamarin templates got new icons that actually match the current VS look:

image

Can we find these icons and use them as they look much better than the one currently in this PR?

@jpobst
Copy link
Contributor

jpobst commented Apr 19, 2024

I guess Classic Xamarin only has good icons for project templates, the item templates still use the very old icons that do not match current VS:

image

@jonathanpeppers
Copy link
Member

Context: #8883 (comment)

Opinion was that the icons for Classic Xamarin.Android within VS 17.9
were better than the icons added in this PR.

Update the *project* templates to use the older icons.

*Item* templates are unchanged, and use the new icon.
@jonpryor jonpryor force-pushed the dev/jonp/jonp-add-project-icons branch from 8540841 to 914b788 Compare May 14, 2024 17:56
@jonpryor jonpryor merged commit 4edf89c into main May 16, 2024
48 checks passed
@jonpryor jonpryor deleted the dev/jonp/jonp-add-project-icons branch May 16, 2024 14:09
grendello added a commit that referenced this pull request May 16, 2024
* main:
  [Mono.Android] AndroidMessageHandler should follow HTTP-308 redirects (#8951)
  [Microsoft.Android.Templates] Add icons to templates (#8883)
  [native] Native call tracing infra + native build system overhaul (#8857)
  [build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.24262.2 (#8949)
  [ci] Re-enable to push to dotnet9 feed (#8950)
  LEGO: Merge pull request 8952
  [ci] Improve maestro artifact publishing (#8945)
grendello added a commit that referenced this pull request May 16, 2024
* main:
  [Mono.Android] AndroidMessageHandler should follow HTTP-308 redirects (#8951)
  [Microsoft.Android.Templates] Add icons to templates (#8883)
  [native] Native call tracing infra + native build system overhaul (#8857)
  [build] fix code-flow from dotnet/installer, .NET 9.0.100-preview.5.24262.2 (#8949)
  [ci] Re-enable to push to dotnet9 feed (#8950)
  LEGO: Merge pull request 8952
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants