Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump binutils to 17.0.6-7.2.2 #8867

Merged
merged 4 commits into from
May 8, 2024

Conversation

grendello
Copy link
Contributor

@grendello grendello commented Apr 11, 2024

Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.1
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.2
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.1
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.2
Changes: dotnet/android-native-tools@L_17.0.6-7.1.0...L_17.0.6-7.1.1
Changes: dotnet/android-native-tools@L_17.0.6-7.1.1...L_17.0.6-7.1.2
Changes: dotnet/android-native-tools@L_17.0.6-7.1.2...L_17.0.6-7.2.0
Changes: dotnet/android-native-tools@L_17.0.6-7.2.0...L_17.0.6-7.2.1
Changes: dotnet/android-native-tools@L_17.0.6-7.2.1...L_17.0.6-7.2.2

This release makes changes to how we build and run the as.exe wrapper, so that it can be verified by API Scan without any issues. Otherwise it is identical to the previous release, using the same version of LLVM.

Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.1
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.1.2
Context: https://github.com/xamarin/xamarin-android-binutils/releases/tag/L_17.0.6-7.2.1
Changes: dotnet/android-native-tools@L_17.0.6-7.1.0...L_17.0.6-7.1.1
Changes: dotnet/android-native-tools@L_17.0.6-7.1.1...L_17.0.6-7.1.2
Changes: dotnet/android-native-tools@L_17.0.6-7.1.2...L_17.0.6-7.2.0
Changes: dotnet/android-native-tools@L_17.0.6-7.2.0...L_17.0.6-7.2.1

This release makes changes to how we build and run the `as.exe` wrapper, so that it can be
verified by API Scan without any issues.  Otherwise it is identical to the previous release, using
the same version of LLVM.

* [ci] Build and sign in a DevDiv pipeline by @pjcollins in dotnet/android-native-tools#7
* [ci] Migrate to the 1ES template by @pjcollins in dotnet/android-native-tools#8
* [ci] Improve binskim scan performance by @pjcollins in dotnet/android-native-tools#11
* [ci] Improve triggers and support test signing by @pjcollins in dotnet/android-native-tools#12
* [ci] Fix unsigned artifact uploading by @pjcollins in dotnet/android-native-tools#13
* [ci] Disable automatic GitHub action trigger by @pjcollins in dotnet/android-native-tools#16
* [ci] Build on performance build pools by @pjcollins in dotnet/android-native-tools#15
* Build `as.exe` on windows by @grendello in dotnet/android-native-tools#10
* [ci] Add API Scan job by @pjcollins in dotnet/android-native-tools#9
*  Fix `as.exe` crash on Windows by @grendello in dotnet/android-native-tools#20
* [ci] Use managed identity for API Scan by @pjcollins in dotnet/android-native-tools#21
* Back to wide strings on Windows + magic encantations by @grendello in dotnet/android-native-tools#22
@jonpryor
Copy link
Member

jonpryor commented Apr 11, 2024

The Linux unit tests are failing:

/mnt/vss/_work/2/s/bin/Release/dotnet/packs/Microsoft.Android.Sdk.Linux/34.0.101/tools/Xamarin.Android.Common.targets(2063,3): error XA3006: stderr | /mnt/vss/_work/2/s/bin/Release/dotnet/packs/Microsoft.Android.Sdk.Linux/34.0.101/tools/Linux/binutils/bin/llc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /mnt/vss/_work/2/s/bin/Release/dotnet/packs/Microsoft.Android.Sdk.Linux/34.0.101/tools/Linux/binutils/bin/../lib/../lib/libLLVMObject.so.17)

which is rather odd, as the #8806 PR didn't experience this, nor did the build for 0db28d3 in https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9347762&view=results (which had some failures, but none in Linux Tests).

Restarting the entire build, for sanity (?).

@jonpryor
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonpryor
Copy link
Member

@grendello
Copy link
Contributor Author

This is likely because we build on Ubuntu 22.04 (https://github.com/xamarin/xamarin-android-binutils/blob/main/build-tools/automation/azure-pipelines.yml#L60)
which has glibc 2.35, while Ubuntu 20.04 (the current LTS, till 2025 I think) has 2.31 - perhaps the tests ran on a bot with the older Ubuntu?

We probably should switch the binutils build bot to 20.04

@grendello grendello changed the title Bump binutils to 17.0.6-7.2.1 (#8806) Bump binutils to 17.0.6-7.2.2 (#8806) Apr 19, 2024
@grendello grendello changed the title Bump binutils to 17.0.6-7.2.2 (#8806) Bump binutils to 17.0.6-7.2.2 Apr 19, 2024
@grendello
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* release/8.0.2xx:
  [Mono.Android] fix potential leak of RunnableImplementors (#8900)
  Bump to xamarin/monodroid@21aed734 (#8905)
  [Xamarin.Android.Build.Tasks] fix detection of "Android libraries" (#8904)
  [ci] Do not use @self annotation for templates (#8783)
  Bump to xamarin/xamarin-android-tools/release/8.0.1xx@d50747cb (#8892)
  [Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages (#8884)
  [ci] Use NuGetAuthenticate@1 (#8877)
  [ci] Migrate to the 1ES template (#8876)
@jonathanpeppers
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* release/8.0.2xx:
  [build] use new Mono archive URL (#8931)
  [Xamarin.Android.Build.Tests] Fix ActionBarSherlock URL (#8926)
@jonathanpeppers jonathanpeppers merged commit b45b88f into release/8.0.2xx May 8, 2024
47 checks passed
@jonathanpeppers jonathanpeppers deleted the dev/grendel/net8-bump-binutils branch May 8, 2024 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants