Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly compare paths #4332

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Properly compare paths #4332

merged 1 commit into from
Feb 26, 2020

Conversation

kant2002
Copy link
Contributor

For some reasons Path.GetFullPath (path) and GetRealPath (path) has values which was different case and it reports bin\Debug\lib\xamarin.android\xbuild\Microsoft as symlink.
Example difference in cases:

d:\xamarin-android\bin\Debug\lib\xamarin.android\xbuild\Microsoft <-> D:\xamarin-android\bin\Debug\lib\xamarin.android\xbuild\Microsoft

Fix #4306

For some reasons `Path.GetFullPath (path)` and `GetRealPath (path)` has values which was different case and it reports `bin\Debug\lib\xamarin.android\xbuild\Microsoft` as symlink.
Example difference in cases:
```
d:\xamarin-android\bin\Debug\lib\xamarin.android\xbuild\Microsoft <-> D:\xamarin-android\bin\Debug\lib\xamarin.android\xbuild\Microsoft
```

Fix dotnet#4306
@jonathanpeppers
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird! 👀

@kant2002
Copy link
Contributor Author

Indeed. Good thing that I can now smoothly build Xamarin to fix real issue which I’m facing

@jonpryor jonpryor merged commit 2722719 into dotnet:master Feb 26, 2020
@kant2002 kant2002 deleted the kant/XA4306-fix branch February 27, 2020 03:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsequent XABuild do not run
4 participants