Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android API-29 enumification and stabilization #3305

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Conversation

gugavaro
Copy link
Contributor

@gugavaro gugavaro commented Jun 27, 2019

API-29 is now Final.

Android API-29 enumification and stabilization

On these changes:

  • Bump Targets/targetSdkVersion to 29
  • Add api-29.params.txt file
  • Add new enums and fix method signatures (map.csv and method map.csv)
  • Fix metadata issues.
  • Update Android Emulator to use 29 image
  • Bump test timeouts
  • Fix test issues.
    [build-tools] Update the logcat timing patterns for API-29
    [logcat processing] Update activity displayed detection
    Fixing some deploy/undeploy apks to emulator
    Ignore exit code for logcat -c
    Allow BuildTest.BuildHasNoWarnings to have up to 1 warning due to be incompatible with Api level 29
  • Fix base class of all classes that Google changed the base to use original base class. i.e.: SpannableString, SpannedString, ... (see metadata.xml)
  • Removing #if !ANDROID_29 condition from StringBuffer.cs and StringBuilder.cs

@grendello
Copy link
Contributor

The GIT issue appears to be gone, however the Azure build now fails on macOS with:

mono --debug /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/mandroid-internal/typenamemap-gen.exe -o typemap \
		/Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/I18N.CJK.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/I18N.MidEast.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/I18N.Other.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/I18N.Rare.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/I18N.West.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/I18N.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Java.Interop.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Microsoft.CSharp.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.Btls.Interface.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.CSharp.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.CompilerServices.SymbolWriter.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.Data.Sqlite.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.Data.Tds.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.Posix.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Mono.Security.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.ComponentModel.Composition.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.ComponentModel.DataAnnotations.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Core.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Data.Services.Client.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Data.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.EnterpriseServices.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.IO.Compression.FileSystem.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.IO.Compression.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.IdentityModel.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Json.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Net.Http.WinHttpHandler.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Net.Http.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Net.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Numerics.Vectors.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Numerics.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Reflection.Context.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Runtime.CompilerServices.Unsafe.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Runtime.Serialization.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Security.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.ServiceModel.Internals.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.ServiceModel.Web.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.ServiceModel.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Transactions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Web.Services.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Windows.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Xml.Linq.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Xml.Serialization.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.Xml.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/System.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Xamarin.Android.NUnitLite.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/mscorlib.dll \
		/Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/Microsoft.Win32.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/Microsoft.Win32.Registry.AccessControl.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/Microsoft.Win32.Registry.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.AppContext.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Buffers.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Collections.Concurrent.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Collections.NonGeneric.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Collections.Specialized.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Collections.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ComponentModel.Annotations.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ComponentModel.EventBasedAsync.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ComponentModel.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ComponentModel.TypeConverter.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ComponentModel.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Console.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Data.Common.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Data.SqlClient.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.Contracts.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.Debug.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.FileVersionInfo.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.Process.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.StackTrace.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.TextWriterTraceListener.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.Tools.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.TraceEvent.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.TraceSource.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Diagnostics.Tracing.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Drawing.Common.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Drawing.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Dynamic.Runtime.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Globalization.Calendars.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Globalization.Extensions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Globalization.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.Compression.ZipFile.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.FileSystem.AccessControl.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.FileSystem.DriveInfo.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.FileSystem.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.FileSystem.Watcher.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.FileSystem.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.IsolatedStorage.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.MemoryMappedFiles.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.Pipes.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.UnmanagedMemoryStream.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.IO.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Linq.Expressions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Linq.Parallel.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Linq.Queryable.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Linq.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Memory.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.AuthenticationManager.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Cache.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.HttpListener.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Mail.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.NameResolution.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.NetworkInformation.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Ping.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Requests.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Security.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.ServicePoint.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Sockets.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.Utilities.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.WebHeaderCollection.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.WebSockets.Client.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Net.WebSockets.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ObjectModel.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.DispatchProxy.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.Emit.ILGeneration.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.Emit.Lightweight.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.Emit.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.Extensions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.TypeExtensions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Reflection.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Resources.Reader.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Resources.ReaderWriter.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Resources.ResourceManager.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Resources.Writer.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.CompilerServices.VisualC.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Extensions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Handles.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.InteropServices.RuntimeInformation.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.InteropServices.WindowsRuntime.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.InteropServices.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Loader.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Numerics.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Serialization.Formatters.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Serialization.Json.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Serialization.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.Serialization.Xml.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Runtime.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.AccessControl.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Claims.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Algorithms.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Cng.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Csp.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.DeriveBytes.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Encoding.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Encryption.Aes.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Encryption.ECDiffieHellman.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Encryption.ECDsa.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Encryption.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Hashing.Algorithms.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Hashing.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.OpenSsl.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Pkcs.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.ProtectedData.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.RSA.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.RandomNumberGenerator.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Cryptography.X509Certificates.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Principal.Windows.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.Principal.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Security.SecureString.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ServiceModel.Duplex.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ServiceModel.Http.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ServiceModel.NetTcp.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ServiceModel.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ServiceModel.Security.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ServiceProcess.ServiceController.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Text.Encoding.CodePages.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Text.Encoding.Extensions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Text.Encoding.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Text.RegularExpressions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.AccessControl.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.Overlapped.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.Tasks.Extensions.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.Tasks.Parallel.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.Tasks.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.Thread.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.ThreadPool.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.Timer.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Threading.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.ValueTuple.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.ReaderWriter.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.XDocument.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.XPath.XDocument.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.XPath.XmlDocument.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.XPath.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.XmlDocument.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.XmlSerializer.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/System.Xml.Xsl.Primitives.dll /Users/vsts/agent/2.153.2/work/1/s/bin/Release/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/Facades/netstandard.dll \
		
typenamemap-gen: Error processing assemblies: Could not load assembly 'Mono.Android, Version=0.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065'. Perhaps it doesn't exist in the Mono for Android profile?
make[1]: *** [typemap.mj] Error 1
make: *** [runtime-service] Error 2

There are also test failures which may have to do with the PR.

@gugavaro gugavaro force-pushed the gugavaro_api29final branch 3 times, most recently from 80c0d73 to 77a051e Compare July 2, 2019 22:28
@gugavaro gugavaro added the do-not-merge PR should not be merged. label Jul 2, 2019
jonpryor pushed a commit that referenced this pull request Jul 5, 2019
Context: e956107
Context: #3305

When `Mono.Android-Test.Library.csproj` was added in e956107 it did
not import our `Configuration.props` file which contains default
paths to the Android tooling that we provision.  This recently caused
a breakage when bumping the `$(TargetFrameworkVersion)` of this
project to v10.0 (within PR #3305) and building against a system
install of XA, as the Android SDK path which was automatically
resolved did not contain `platforms/android-29/android.jar`.

Importing `Configuration.props` file should fix this build failure.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like the changes for: https://github.com/xamarin/xamarin-android/pull/3305/files#diff-c740831c14f44e704a255b944359df01R25

Will be required because the previous app was built with v9.0 and VS 2017. We'll have to make this test check for the presence of v9.0 going forward.

Copy link
Contributor

@dellis1972 dellis1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. There are however allot of white space changes in the various file which are just adding noise to the PR. Might be nice to clean those up a bit if possible.

@artur-malendowicz-gain
Copy link

When will this be merged? I would like to get access to BiometricManager ;)

@gugavaro gugavaro force-pushed the gugavaro_api29final branch 2 times, most recently from dfc0096 to a9be149 Compare July 12, 2019 01:14
@gugavaro
Copy link
Contributor Author

gugavaro commented Jul 12, 2019

When will this be merged? I would like to get access to BiometricManager ;)

@artur-malendowicz-gain As soon as we are able to get a good build. API Level 29 has some breakages that I am working on to fix it.

@radekdoulik
Copy link
Member

I looked into the crash in the XF test today.

The cause of this is that XF assembly, built against API 28, calls to SpannableStringInternal methods with SpannableString instances. Like here:

  .method public hidebysig static void  RecalculateSpanPositions([Mono.Android]Android.Widget.TextView textView,
                                                                 [Xamarin.Forms.Core]Xamarin.Forms.Label element,
                                                                 [Mono.Android]Android.Text.SpannableString spannableString,
                                                                 [Xamarin.Forms.Core]Xamarin.Forms.SizeRequest finalSize) cil managed
  {
    .custom instance void [mscorlib]System.Runtime.CompilerServices.ExtensionAttribute::.ctor() = ( 01 00 00 00 ) 
    // Code size       492 (0x1ec)
    .maxstack  6
    .locals init ([Mono.Android]Android.Text.Layout V_0,
             float64 V_1,
             int32 V_2,
             int32 V_3,
             [mscorlib]System.Collections.Generic.IList`1<int32> V_4,
             [Xamarin.Forms.Core]Xamarin.Forms.Size V_5,
             int32 V_6,
             [Mono.Android]Java.Lang.Class V_7,
             [Xamarin.Forms.Core]Xamarin.Forms.Span V_8,
             [Mono.Android]Java.Lang.Object V_9,
             [Mono.Android]Java.Lang.Object V_10,
             int32 V_11,
             int32 V_12,
             float32 V_13,
             float32 V_14,
             int32 V_15,
             int32 V_16,
             float64[] V_17,
             float64 V_18,
             int32 V_19,
             int32 V_20,
             int32 V_21,
             [Xamarin.Forms.Core]Xamarin.Forms.Region V_22)
...
    IL_00d0:  ldarg.2
    IL_00d1:  ldloc.s    V_6
    IL_00d3:  ldarg.2
    IL_00d4:  callvirt   instance int32 [Mono.Android]Android.Text.SpannableStringInternal::Length()
    IL_00d9:  ldloc.s    V_7
    IL_00db:  callvirt   instance int32 [Mono.Android]Android.Text.SpannableStringInternal::NextSpanTransition(int32,
                                                                                                               int32,
                                                                                                               [Mono.Android]Java.Lang.Class)
...

And because API 29 has breaking change in the SpannableString, it is now based directly on Java.Lang.Object (in API 29), while before it was based on SpannableStringInternal, we endup calling methods from wrong class.

The inheritance change:

API 28:

public partial class SpannableString : Android.Text.SpannableStringInternal, Android.Text.IGetChars, Android.Text.ISpannable, Java.Lang.ICharSequence { ...}

API 29:

public partial class SpannableString : Java.Lang.Object, Android.Text.IGetChars, Android.Text.ISpannable, Java.Lang.ICharSequence { ... }

So when XF code calls to NextSpanTransition, the base class method is used. It is a wrong method in API 29 though, because the SpannableString is not based on SpannableStringInternal anymore.

It looks like the methods tables are wrong here and so we end up in GetChars methods instead. I was not sure about the details here, so I tried to add debug prints to XF's RecalculateSpanPositions and SpannableString::GetChars. It indeed looks like the above mentioned callvirt

callvirt  instance int32 [Mono.Android]Android.Text.SpannableStringInternal::NextSpanTransition(int32, int32, [Mono.Android]Java.Lang.Class)

ends up in SpannableString::GetChars.

@gugavaro gugavaro force-pushed the gugavaro_api29final branch 2 times, most recently from d59b6d1 to f7b57b1 Compare July 17, 2019 15:44
@gugavaro gugavaro force-pushed the gugavaro_api29final branch 5 times, most recently from fa1ffaf to c48623d Compare July 19, 2019 22:11
@jonpryor jonpryor added the full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps) label Jul 25, 2019
@jonpryor
Copy link
Member

Added the full-mono-integration-build label and restarted the Jenkins build: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-release/1705/

@gugavaro gugavaro force-pushed the gugavaro_api29final branch 2 times, most recently from 1d20d1e to 98b2a33 Compare July 27, 2019 17:10
jonpryor pushed a commit to xamarin/xamarin-android-api-compatibility that referenced this pull request Jul 29, 2019
Update assemblies for API-29, mono/mono@761220d9

Context: dotnet/android#3305

Commit xamarin/xamarin-android/master@0c9f83b7 included a bump to
mono/mono@761220d9, which [broke API compatibility][0],
removing `System.Diagnostics.Tracing.EventCounter.Dispose()`:

	<h3>Type Changed: System.Diagnostics.Tracing.EventCounter</h3>
	<p>Removed method:</p>
	<pre>
	  <span class='removed removed-method breaking' data-is-breaking>public virtual void Dispose ();</span>
	</pre>

This was introduced by [dotnet/standard@af001b83][1] and the
introduction of a new `System.Diagnostics.Tracing.DiagnosticCounter`
base class.  This is thus an API-compatible change.

Meanwhile, [xamarin-android PR 3305][2] adds support for
[Android 10.0 (API-29)][3], adding several new types & members.
API-29 requires a new `inter-api-extra-v9.0-v10.0.txt` file for
inter-API comparisons due to "compatible" changes which
`mono-api-html` reports as errors.  These include

  * Changing the base class of
    `Android.App.ActivityManager.RecentTaskInfo` and
    `Android.App.ActivityManager.RecentTaskInfo.RunningTaskInfo` to
    `Android.App.TaskInfo`, from `Java.Lang.Object`.

  * The base class of `Java.Util.Concurrent.Atomic.DoubleAccumulator`,
    `DoubleAdder`, `LongAccumulator`, and `LongAdder` was changed from
    `Java.Util.Concurrent.Atomic.Striped64` to `Java.Lang.Number`.
    
    This *is* a breaking change, but `Striped64` inherited from
    `Number`, so all method invocations were already "based on"
    `Number` method invocations.  This change should only alter
    compatibility when performing a reference conversion to
    `Striped64`:
    
        Java.Util.Concurrent.Atomic.Striped64 = new Java.Util.Concurrent.Atomic.DoubleAccumulator();
        // Previously valid, now a CS0029

    We believe that this change shouldn't actually impact anyone.

  * `Android.Text.SpannableStringInternal` methods were changed from
    non-`virtual` to `virtual`, because on the Java side the
    `android.text.SpannableStringInternal` class was removed, which
    resulted in a [runtime crash][4].  The chosen fix was to make
    these methods `virtual`, so that they could be appropriately
    overridden and dispatched to the correct Java-side type.

[0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/668/API_20Compatibility_20Checks/
[1]: dotnet/standard@af001b8#diff-5d9a22f9ff5db529e1ea22efb9858d01
[2]: dotnet/android#3305
[3]: https://web.archive.org/web/20190726091025/https://developer.android.com/preview/features
[4]: dotnet/android#3305 (comment)
jonpryor pushed a commit to xamarin/xamarin-android-api-compatibility that referenced this pull request Jul 29, 2019
Update assemblies for API-29, mono/mono@761220d9

Context: dotnet/android#3305

Commit xamarin/xamarin-android/master@0c9f83b7 included a bump to
mono/mono@761220d9, which [broke API compatibility][0],
removing `System.Diagnostics.Tracing.EventCounter.Dispose()`:

	<h3>Type Changed: System.Diagnostics.Tracing.EventCounter</h3>
	<p>Removed method:</p>
	<pre>
	  <span class='removed removed-method breaking' data-is-breaking>public virtual void Dispose ();</span>
	</pre>

This was introduced by [dotnet/standard@af001b83][1] and the
introduction of a new `System.Diagnostics.Tracing.DiagnosticCounter`
base class.  This is thus an API-compatible change.

Meanwhile, [xamarin-android PR 3305][2] adds support for
[Android 10.0 (API-29)][3], adding several new types & members.
API-29 requires a new `inter-api-extra-v9.0-v10.0.txt` file for
inter-API comparisons due to "compatible" changes which
`mono-api-html` reports as errors.  These include

  * Changing the base class of
    `Android.App.ActivityManager.RecentTaskInfo` and
    `Android.App.ActivityManager.RecentTaskInfo.RunningTaskInfo` to
    `Android.App.TaskInfo`, from `Java.Lang.Object`.

  * The base class of `Java.Util.Concurrent.Atomic.DoubleAccumulator`,
    `DoubleAdder`, `LongAccumulator`, and `LongAdder` was changed from
    `Java.Util.Concurrent.Atomic.Striped64` to `Java.Lang.Number`.
    
    This *is* a breaking change, but `Striped64` inherited from
    `Number`, so all method invocations were already "based on"
    `Number` method invocations.  This change should only alter
    compatibility when performing a reference conversion to
    `Striped64`:
    
        Java.Util.Concurrent.Atomic.Striped64 = new Java.Util.Concurrent.Atomic.DoubleAccumulator();
        // Previously valid, now a CS0029

    We believe that this change shouldn't actually impact anyone.

  * `Android.Text.SpannableStringInternal` methods were changed from
    non-`virtual` to `virtual`, because on the Java side the
    `android.text.SpannableStringInternal` class was removed, which
    resulted in a [runtime crash][4].  The chosen fix was to make
    these methods `virtual`, so that they could be appropriately
    overridden and dispatched to the correct Java-side type.

[0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/668/API_20Compatibility_20Checks/
[1]: dotnet/standard@af001b8#diff-5d9a22f9ff5db529e1ea22efb9858d01
[2]: dotnet/android#3305
[3]: https://web.archive.org/web/20190726091025/https://developer.android.com/preview/features
[4]: dotnet/android#3305 (comment)
@gugavaro gugavaro force-pushed the gugavaro_api29final branch 2 times, most recently from 59d8d59 to cd18b80 Compare July 30, 2019 15:20
@gugavaro gugavaro removed the do-not-merge PR should not be merged. label Jul 31, 2019
@jonpryor jonpryor merged commit 936a09d into master Jul 31, 2019
jonpryor pushed a commit that referenced this pull request Jul 31, 2019
API-29/v10.0 is now stable.

Bumps to xamarin/xamarin-android-api-compatibility@da270b88.

Bump Targets/`$(TargetSdkVersion)` to v10.0 (API-29).

Add `src/Mono.Android/Profiles/api-29.params.txt` for parameter names.

Add new enums and fix method signatures (`map.csv`, `methodmap.csv`).

Fix metadata whitespace formatting.

Update Android Emulator to use 29 image

Bump test timeouts.

Fix test issues:

  * [build-tools] Update the logcat timing patterns for API-29
  * [logcat processing] Update activity displayed detection
  * Fixing some deploy/undeploy apks to emulator
  * Ignore exit code for `adb logcat -c`
  * Allow BuildTest.BuildHasNoWarnings to have up to 1 warning due to
    be incompatible with Api level 29

Remove `#if !ANDROID_29` condition from `StringBuffer.cs` and
`StringBuilder.cs`, added in 2cace0b, to preserve API compatibility.
@artur-malendowicz-gain
Copy link

@jonpryor any ETA when it will be available in stable/preview release?

jonpryor pushed a commit that referenced this pull request Jul 31, 2019
Context: e956107
Context: #3305

When `Mono.Android-Test.Library.csproj` was added in e956107 it did
not import our `Configuration.props` file which contains default
paths to the Android tooling that we provision.  This recently caused
a breakage when bumping the `$(TargetFrameworkVersion)` of this
project to v10.0 (within PR #3305) and building against a system
install of XA, as the Android SDK path which was automatically
resolved did not contain `platforms/android-29/android.jar`.

Importing `Configuration.props` file should fix this build failure.
@gugavaro gugavaro deleted the gugavaro_api29final branch July 31, 2019 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants