[Xamarin.Android.Build.Tasks] fix for MonoPackageManager.java from 16.1 #3128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://work.devdiv.io/899432
There is a #deletebinobj problem if you take an existing project built
with 16.1 and build with 16.2/master.
Get an error such as:
Reviewing
obj\Debug\90\android\src\mono
, there is aMonoPackageManager.java
andMonoPackageManager_Resources.java
thathave a duplicate class.
In 5a9d1a6, we had already tried to fix this, but the
_CleanupOldStaticResources
target was not running? It appears that16.1 is not producing the
ApplicationRegistration.java
file it islooking for.
The path we were using for a few files wasn't right:
Should actually be:
But then looking at
<GenerateJavaStubs/>
, we still produce thisfile? I think we should instead use
NotifyTimeZoneChanges.java
forthis check. We don't need to delete, or look for
ApplicationRegistration.java
.Then I found another problem, in that
_GeneratePackageManagerJava
and
_CompileJava
need to re-run. I added the stamp files for theseMSBuild targets to the
@(_OldStaticResources)
item group to fixthis.