Skip to content

Commit

Permalink
Fixes after main merge
Browse files Browse the repository at this point in the history
Still doesn't build, libunwind cmake fails, but we're a step closer.
  • Loading branch information
grendello committed Mar 27, 2024
1 parent 5ed6afb commit 8efc08b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ IList<string> MergeManifest (NativeCodeGenState codeGenState, Dictionary<string,
var tdCache = new TypeDefinitionCache ();
(List<TypeDefinition> allJavaTypes, List<TypeDefinition> javaTypesForJCW) = ScanForJavaTypes (resolver, tdCache, assemblies, userAssemblies, useMarshalMethods);
var jcwContext = new JCWGeneratorContext (arch, resolver, assemblies.Values, javaTypesForJCW, tdCache, useMarshalMethods);
var jcwGenerator = new JCWGenerator (Log, jcwContext);
var jcwGenerator = new JCWGenerator (Log, jcwContext, IntermediateOutputDirectory);
bool success;

if (generateJavaCode) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,8 @@ void AddEnvironment ()
Log,
assemblyCount,
uniqueAssemblyNames,
EnsureCodeGenState (targetArch)
EnsureCodeGenState (targetArch),
mmTracingMode
);
} else {
marshalMethodsAsmGen = new MarshalMethodsNativeAssemblyGenerator (
Expand Down
6 changes: 4 additions & 2 deletions src/Xamarin.Android.Build.Tasks/Utilities/JCWGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,15 @@ class JCWGenerator
{
readonly TaskLoggingHelper log;
readonly JCWGeneratorContext context;
readonly string intermediateOutputDirectory;

public MarshalMethodsClassifier? Classifier { get; private set; }

public JCWGenerator (TaskLoggingHelper log, JCWGeneratorContext context)
public JCWGenerator (TaskLoggingHelper log, JCWGeneratorContext context, string intermediateOutputDirectory)
{
this.log = log;
this.context = context;
this.intermediateOutputDirectory = intermediateOutputDirectory;
}

/// <summary>
Expand Down Expand Up @@ -88,7 +90,7 @@ public bool GenerateAndClassify (string androidSdkPlatform, string outputPath, s
);
}

MarshalMethodsClassifier MakeClassifier () => new MarshalMethodsClassifier (context.Arch, context.TypeDefinitionCache, context.Resolver, log);
MarshalMethodsClassifier MakeClassifier () => new MarshalMethodsClassifier (context.Arch, context.TypeDefinitionCache, context.Resolver, intermediateOutputDirectory, log);

bool ProcessTypes (bool generateCode, string androidSdkPlatform, MarshalMethodsClassifier? classifier, string? outputPath, string? applicationJavaClass)
{
Expand Down

0 comments on commit 8efc08b

Please sign in to comment.