Skip to content

Commit

Permalink
[build] keep $(DotNetPreviewVersionBand) on 8.0.100 (#8841)
Browse files Browse the repository at this point in the history
Context: https://github.com/xamarin/xamarin-android/blob/2ff1a5f67d6da4ebac507a1b248809388f23e7c7/eng/Versions.props#L15

As we moved to the .NET 8.0.200 SDK, we inadvertently changed the
version band of the Android workload:

    Microsoft.NET.Sdk.Android.Manifest-8.0.200

This would prevent 8.0.100 .NET SDKs from using the latest Android
workload.

Pin `$(DotNetPreviewVersionBand)` to 8.0.100 to fix this.
  • Loading branch information
jonathanpeppers committed Mar 27, 2024
1 parent 20d9605 commit 0d97e20
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<!-- Match the first three version numbers and append 00 -->
<VersionBand Condition=" '$(VersionBand)' == '' ">$([System.Text.RegularExpressions.Regex]::Match($(MicrosoftDotnetSdkInternalPackageVersion), `^\d+\.\d+\.\d`))00</VersionBand>
<VersionSuffixRegex>\-(preview|rc|alpha).\d+</VersionSuffixRegex>
<DotNetPreviewVersionBand Condition=" '$(DotNetPreviewVersionBand)' == '' ">$(VersionBand)$([System.Text.RegularExpressions.Regex]::Match($(MicrosoftDotnetSdkInternalPackageVersion), $(VersionSuffixRegex)))</DotNetPreviewVersionBand>
<DotNetPreviewVersionBand Condition=" '$(DotNetPreviewVersionBand)' == '' ">8.0.100</DotNetPreviewVersionBand>
<DotNetSdkManifestsFolder>$(DotNetPreviewVersionBand)</DotNetSdkManifestsFolder>
<DotNetMonoManifestVersionBand>8.0.100</DotNetMonoManifestVersionBand>
<DotNetEmscriptenManifestVersionBand>8.0.100</DotNetEmscriptenManifestVersionBand>
Expand Down

0 comments on commit 0d97e20

Please sign in to comment.