Merge shared files #734
Merged
Merge shared files #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any troubles using 10 days for both .net framework and .net core. I have re-run the failing pipelines and the previously failing tests look like random ones. |
karinazhou
reviewed
Oct 5, 2020
src/Microsoft.Data.SqlClient/src/Microsoft/Data/OperationAbortedException.cs
Show resolved
Hide resolved
karinazhou
approved these changes
Oct 6, 2020
cheenamalhotra
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of more identical or similar files.
The only notable difference is in SignatureVerificationCache.cs
netcore:
_cache.Set(cacheLookupKey, result, DateTimeOffset.UtcNow.AddDays(10));netfx:
_cache.Set(cacheLookupKey, result, DateTimeOffset.UtcNow.AddHours(8));I chose the 10 days but I think this needs consideration before merging.