Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename App Context name for enabling Managed SNI on Windows #548

Merged
merged 1 commit into from
May 1, 2020

Conversation

cheenamalhotra
Copy link
Member

  • Remove ConfigurationManager dependency from nuspec
  • Standardize App Context switch name for "UseManagedNetworkingOnWindows"

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are updating the switch name, you'll also need to update the BUILDGUIDE and DataTestUtility.cs. Then I assume the pipeline will need to be updated, too.

@David-Engel
Copy link
Contributor

If you are updating the switch name, you'll also need to update the BUILDGUIDE and DataTestUtility.cs. Then I assume the pipeline will need to be updated, too.

Looks like you just did that. :)

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to think about what the pipelines should look like for building slightly older code, too. Since this switch just came out in 2.0 previews, maybe we don't need to support the previous name.

@cheenamalhotra
Copy link
Member Author

Be sure to think about what the pipelines should look like for building slightly older code, too. Since this switch just came out in 2.0 previews, maybe we don't need to support the previous name.

Pipelines are run based on config.json property UseManagedSNIOnWindows which is untouched, and AppContext name is taken care in DataTestUtility, so we are good :)

@cheenamalhotra cheenamalhotra merged commit 09705f5 into dotnet:master May 1, 2020
@cheenamalhotra cheenamalhotra changed the title Consistency updates Rename App Context name for enabling Managed SNI on Windows May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants