Add "Transaction Id" and "Client Version" in Diagnostic Source traces #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
karinazhou,
JRahnama,
David-Engel and
DavoudEshtehari
David-Engel
reviewed
Apr 7, 2020
There was a problem hiding this comment.
This can be optimized to simply pass the SqlTransaction object to the diagnostic events. Then use transaction?.InternalTransaction?.TransactionId inside the anonymous type we create. This avoids the constant null checking in the calls to the diagnostic listener when there are no listeners enabled and looks cleaner, IMO.
David-Engel
approved these changes
Apr 7, 2020
|
Uploading NuGet Package for validation: Usage: |
David-Engel
reviewed
Apr 9, 2020
...Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlClientDiagnosticListenerExtensions.cs
Outdated
Show resolved
Hide resolved
|
👍 Looks good to me, thanks for making these changes! |
JRahnama
approved these changes
Apr 15, 2020
karinazhou
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing request made by @davidmikh here: #93 (comment)
Hi @davidmikh
As per our offline discussions, I've made this PR to include "Transaction Id" to
SqlCommandandSqlTransactionevents and "Client Version" inSqlConnectionevents.Regarding other 2 requests:
SqlTransactionevents--
Connection.ClientConnectionIdcontains this info.SqlConnectionopen events--
Connection.ServerVersioncontains this info.Let me know if you need additional info from here.
P.S. Diagnostic Tests to be enabled in a separate PR (WIP @JRahnama PR #517)