Fix ConnectionTime and ClientConnectionId reported by SqlStatistics #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, the
ConnectionTimeis reported asMaxValue/1000because the_closeTimestampwas not set properly. Further, calling RetrieveStatistics multiple times causes theConnectionTimeto increase exponentially because the total connection time wasSafeAdded to the previously saves_connectionTime. The_connectionTimeshould be overwritten instead.Before the change, when the connection is closed, the ClientConnectionId is set to empty and it's unavailable to the user. The new change allows the user to access the ClientConnectionId even after the connection is closed.