Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX | Revert the change to TargetFrameworkMonikerAssemblyAttributesPath from PR #2497 #2725

Conversation

JRahnama
Copy link
Member

This PR reverts the unintentional change made in PR #2497 to the .NET Core project file regarding the TargetFrameworkMonikerAssemblyAttributesPath.

@JRahnama JRahnama added the 🐛 Bug! Something isn't right ! label Jul 26, 2024
@JRahnama JRahnama added this to the 6.0-preview1 milestone Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (f7ab115) to head (39440ef).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2725      +/-   ##
==========================================
- Coverage   72.81%   71.77%   -1.04%     
==========================================
  Files         311      308       -3     
  Lines       61694    62303     +609     
==========================================
- Hits        44922    44719     -203     
- Misses      16772    17584     +812     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.03% <ø> (-1.15%) ⬇️
netfx 69.72% <ø> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari merged commit 38ce399 into dotnet:main Jul 26, 2024
131 checks passed
@JRahnama JRahnama deleted the revert-changes-to-TargetFrameworkMonikerAssemblyAttributesPath branch August 19, 2024 16:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants