Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge common code base for DBReferenceCollection #2403

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

JRahnama
Copy link
Member

@JRahnama JRahnama commented Mar 12, 2024

Addresses DbReferenceCollection for #1261

@JRahnama JRahnama added the ➕ Code Health Changes related to source code improvements label Mar 12, 2024
@JRahnama JRahnama added this to the 6.0-preview1 milestone Mar 12, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 96.84211% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.80%. Comparing base (769b982) to head (34805b4).
Report is 4 commits behind head on main.

❗ Current head 34805b4 differs from pull request most recent head 04eb9db. Consider uploading reports for the commit 04eb9db to get more accurate results

Files Patch % Lines
...crosoft/Data/ProviderBase/DbReferenceCollection.cs 96.84% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   72.71%   66.80%   -5.91%     
==========================================
  Files         310      303       -7     
  Lines       61885    61481     -404     
==========================================
- Hits        44997    41070    -3927     
- Misses      16888    20411    +3523     
Flag Coverage Δ
addons ∅ <ø> (∅)
netcore 71.01% <96.84%> (-5.90%) ⬇️
netfx 64.67% <95.78%> (-5.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just make sure not to leave any unused files behind.

Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JRahnama
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@David-Engel David-Engel merged commit 1594cc5 into dotnet:main Mar 29, 2024
142 of 151 checks passed
@JRahnama JRahnama deleted the code-mergedb/dbreferencecollection branch May 6, 2024 21:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Changes related to source code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants