Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to include note about existing issues with Async APIs #2118

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

cheenamalhotra
Copy link
Member

@DavoudEshtehari
Copy link
Member

DavoudEshtehari commented Aug 10, 2023

Thanks @cheenamalhotra for actively continuing contribution here. I'd rather introducing a new section for SqlClient's known issues under ADO.net doc.

@David-Engel
Copy link
Contributor

David-Engel commented Aug 10, 2023

I'd rather introducing a new section for SqlClient's known issues under ADO.net doc.

@DavoudEshtehari
Cheena discussed this with me and I initially proposed the same thing. However, given the impact of these known issues and the fact that there is no quick fix coming, making them apparent in the API docs, where devs are more likely to see them, makes it more likely that they will be able to solve their issues quickly, when they run into them.

@DavoudEshtehari DavoudEshtehari added the 📃 Documentation Use this label for any documentation changes label Aug 10, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview4 milestone Aug 10, 2023
Co-authored-by: David Engel <dengel1012@gmail.com>
@cheenamalhotra
Copy link
Member Author

cheenamalhotra commented Aug 10, 2023

I'd rather introducing a new section for SqlClient's known issues under ADO.net doc.

You should do that too IMO for lesser popular issues but with significant impact along-with mitigations/solutions - and pull them in API docs when they become more popular and not fixable in short term.

The more awareness and mitigations driver docs can provide will eventually reduce the amount of repeated questions from customers.

@David-Engel David-Engel merged commit b82b1eb into dotnet:main Aug 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📃 Documentation Use this label for any documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants