Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore | Upgrade Azure Identity from 1.7.0 to 1.8.0 #1921

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

lcheunglci
Copy link
Contributor

@lcheunglci lcheunglci commented Feb 8, 2023

This upgrade should resolve the following issues with the MSAL caching being enabled by default.
#1919
#1900

Also upgraded some related dependencies.

@lcheunglci lcheunglci changed the title chore Upgrade the dependency for AzureIdentity and related dependencies chore | Upgrade Azure Identity from 1.7.0 to 1.8.0 Feb 8, 2023
@lcheunglci lcheunglci changed the title chore | Upgrade Azure Identity from 1.7.0 to 1.8.0 Chore | Upgrade Azure Identity from 1.7.0 to 1.8.0 Feb 8, 2023
@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 8, 2023

Why do you need to be explicit about the dependencies of a Dependency??

@lcheunglci
Copy link
Contributor Author

The other dependencies aren't necessarily required in fact none of them has a direct dependency on Azure Identity. I was going the release notes and felt it might be a nice to have and it actually makes more sense that I revert them as they should be upgraded in a sperate PR when it becomes required. Thanks!

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 70.26% // Head: 70.38% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (81a6198) compared to base (8156ff9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
+ Coverage   70.26%   70.38%   +0.12%     
==========================================
  Files         292      292              
  Lines       61732    61750      +18     
==========================================
+ Hits        43376    43465      +89     
+ Misses      18356    18285      -71     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.80% <ø> (+0.36%) ⬆️
netfx 69.08% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 50.89% <0.00%> (-0.90%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.63% <0.00%> (-0.59%) ⬇️
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs 86.84% <0.00%> (-0.53%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 65.85% <0.00%> (-0.44%) ⬇️
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 95.91% <0.00%> (-0.35%) ⬇️
...ient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs 57.38% <0.00%> (-0.25%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.02% <0.00%> (-0.17%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 73.64% <0.00%> (-0.10%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.42% <0.00%> (+0.05%) ⬆️
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 72.97% <0.00%> (+0.09%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcheunglci lcheunglci marked this pull request as ready for review February 14, 2023 02:19
@lcheunglci lcheunglci merged commit 85edec9 into dotnet:main Feb 22, 2023
@lcheunglci lcheunglci added this to the 5.2.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants