Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: Add ARM64 support when targeting .NET Framework #1828

Merged
merged 23 commits into from
Nov 10, 2022

Conversation

David-Engel
Copy link
Contributor

@David-Engel David-Engel commented Nov 4, 2022

The CI pipelines don't run tests on ARM64 + .NET Framework and I'm having a hard time getting an ARM64 Windows VM to build + run MDS tests from the command line with VS 2022 Preview 6 installed.

Test can be run through the VS GUI, though, you just have to manually filter through expected failures. Doing that identified a bug in the build options of the ARM SNI binaries that resulted in asserts popping up even when using the release binaries. That will be addressed separately in a future SNI release.

Consider this "feature" experimental, for now.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 71.47% // Head: 71.22% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (50d6e76) compared to base (760510c).
Patch coverage: 35.74% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   71.47%   71.22%   -0.25%     
==========================================
  Files         291      291              
  Lines       61304    61391      +87     
==========================================
- Hits        43814    43725      -89     
- Misses      17490    17666     +176     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.95% <ø> (-0.09%) ⬇️
netfx 69.08% <35.74%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs 68.24% <0.00%> (-0.15%) ⬇️
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 57.14% <35.92%> (-23.37%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 78.57% <0.00%> (-3.58%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
...crosoft/Data/ProviderBase/DbReferenceCollection.cs 92.63% <0.00%> (-3.16%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.36% <0.00%> (-0.44%) ⬇️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 73.16% <0.00%> (-0.39%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama JRahnama merged commit 1bb1890 into dotnet:main Nov 10, 2022
@Matteo-T
Copy link

Matteo-T commented Nov 10, 2022

Hi @David-Engel / @JRahnama

Nice! When can I expect this to show up in MDS3.x? Pretty please... :)

It would HELP our users on Visual Studio 2022 and SSDT (17.5 Previews) which is on MDS3.1.1 a lot. We can chat offline and bounce around ideas with other folks who are working on this (I'm just the messenger for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants