Improve error message when adding wrong type to SqlParameterCollection

[ErikEJ]

(to help conversions from System.Data.SqlClient)

fixes #1546

[DavoudEshtehari]

Thanks @ErikEJ
Could you address the ParametersTest.CodeCoverageSqlClient failure too?

[johnnypham]

Test is still failing.

[DavoudEshtehari]

LGTM
For the sake of code coverage, may I ask you to include the following line of code in this block, please?

DataTestUtility.AssertThrowsWrapper<IndexOutOfRangeException>(() => opc["@p1"] = null, "A SqlParameter with ParameterName '@p1' is not contained by this SqlParameterCollection.");

[ErikEJ]

@DavoudEshtehari I have added the line, not sure how it releates to this PR...

[Wraith2]

It doesn't, you're just getting columbo'ed ("just one more thing...") since code coverage is poor in places and you're editing the file.

[ErikEJ]

Happy to do a separate PR to increase code coverage.

Is there an issue for that?

[DavoudEshtehari]

Happy to hear it @ErikEJ

I'm afraid we don't have an active issue for code coverage. We're working to add the code coverage report to our pipelines to verify any digression instantly that would be helpful to detect and improve it with the public.
In the meantime, you can use the internal reports if you had permission:

• net core
• net fx