Move to Shared for TdsEnums.cs #1483
Conversation
…and to verify out of range for LocaleId
…rator and GetService for netfx and CreateCommandBuilder for both
…and fix netfx build due to typo in enum
| public const int SQL2005_MAJOR = 0x72; // the high-byte is sufficient to distinguish later versions | ||
| public const int SQL2008_MAJOR = 0x73; | ||
| public const int SQl2012_MAJOR = 0x74; | ||
| public const int SQL2012_MAJOR = 0x74; |
There was a problem hiding this comment.
This change wasn't made in the original PR. I thought it would be ok to change it since these fields aren't included in the public refs.
There was a problem hiding this comment.
That's my fault but as problems go it's a small one and I agree that it should have no visible impact.
Codecov Report
@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
- Coverage 69.68% 69.56% -0.13%
==========================================
Files 331 330 -1
Lines 66503 66485 -18
==========================================
- Hits 46345 46250 -95
- Misses 20158 20235 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/AAsyncCallContext.cs
Outdated
Show resolved
Hide resolved
This reverts commit fc5f0b8.
| public static readonly decimal SQL_SMALL_MONEY_MAX = new decimal(214748.3647); | ||
|
|
||
| public static readonly decimal SQL_SMALL_MONEY_MIN = new(-214748.3648); | ||
| public static readonly decimal SQL_SMALL_MONEY_MAX = new(214748.3647); |
There was a problem hiding this comment.
Nit: There are number of naming rule violations: Missing prefix s_ in this file.
Remake of #1369. I made an error when resolving merge conflicts in the original PR and it was faster to just cherry pick the original commits to a new branch.